1882329 - StackWalk has two disagreeing checks for support on Linux

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[Patrycja Rosa [:ptrcnull] (she/her)]

MOZ_STACKWALK_SUPPORT_LINUX only checks whether it's a GNU-compatible compiler on x86/ppc, or if we have _unwind_backtrace; later, in the actual implementation, HAVE___LIBC_STACK_END ( which is just a glibc version check ) is used for Linux, and fails with #error Unsupported configuration when that isn't met.
To avoid compilation errors on systems that don't use GNU Libc, the first check could also ensure HAVE___LIBC_STACK_END and disable StackWalk when it's not available.

Comment 1

[Patrycja Rosa [:ptrcnull] (she/her)]

Attachment: Bug 1882329 - Make StackWalk Linux support check more specific r=glandium

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:glandium, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeca81e418bb
Make StackWalk Linux support check more specific r=glandium

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/aeca81e418bb