1882393 - Minor UTF-8 table formatting difference in ui-test-apk task logs

Reporter

Description

•

1 year ago

Minor UTF-8 issue I'm seeing with legibilitiy on Oak branch ui-test-apk tasks

Current:

[task 2024-02-27T19:46:44.563Z] ┌─────────┬──────────────────────┬──────────┬────────────────┬──────────────────────────────┬─────────────────────┐
[task 2024-02-27T19:46:44.563Z] │ OUTCOME │      MATRIX ID       │ APP NAME │ TEST FILE NAME │       TEST AXIS VALUE        │    TEST DETAILS     │
[task 2024-02-27T19:46:44.563Z] ├─────────┼──────────────────────┼──────────┼────────────────┼──────────────────────────────┼─────────────────────┤
[task 2024-02-27T19:46:44.563Z] │ failure │ matrix-1rtc3bogrwgqm │ app.apk  │ N/A            │ oriole-31-en_US-portrait     │ Application crashed │
[task 2024-02-27T19:46:44.563Z] │ success │ matrix-1rtc3bogrwgqm │ app.apk  │ N/A            │ redfin-30-en_US-portrait     │ ---                 │
[task 2024-02-27T19:46:44.564Z] │ success │ matrix-1rtc3bogrwgqm │ app.apk  │ N/A            │ x1q-29-en_US-portrait        │ ---                 │
[task 2024-02-27T19:46:44.564Z] │ success │ matrix-1rtc3bogrwgqm │ app.apk  │ N/A            │ java-30-en_US-portrait       │ ---                 │
[task 2024-02-27T19:46:44.564Z] │ success │ matrix-1rtc3bogrwgqm │ app.apk  │ N/A            │ Pixel2.arm-27-en_US-portrait │ ---                 │
[task 2024-02-27T19:46:44.564Z] └─────────┴──────────────────────┴──────────┴────────────────┴──────────────────────────────┴─────────────────────┘

Oak:

[task 2024-02-22T20:36:13.011Z] ????????????????????????????????????????????????????????????????????????????????????????????????????????????
[task 2024-02-22T20:36:13.011Z] ? OUTCOME ?      MATRIX ID       ? APP NAME ? TEST FILE NAME ?       TEST AXIS VALUE        ? TEST DETAILS ?
[task 2024-02-22T20:36:13.011Z] ????????????????????????????????????????????????????????????????????????????????????????????????????????????
[task 2024-02-22T20:36:13.011Z] ? success ? matrix-1l4jznrvnebbr ? app.apk  ? N/A            ? java-30-en_US-portrait       ? ---          ?
[task 2024-02-22T20:36:13.011Z] ? success ? matrix-1l4jznrvnebbr ? app.apk  ? N/A            ? oriole-31-en_US-portrait     ? ---          ?
[task 2024-02-22T20:36:13.011Z] ? success ? matrix-1l4jznrvnebbr ? app.apk  ? N/A            ? x1q-29-en_US-portrait        ? ---          ?
[task 2024-02-22T20:36:13.011Z] ? success ? matrix-1l4jznrvnebbr ? app.apk  ? N/A            ? redfin-30-en_US-portrait     ? ---          ?
[task 2024-02-22T20:36:13.011Z] ? success ? matrix-1l4jznrvnebbr ? app.apk  ? N/A            ? Pixel2.arm-27-en_US-portrait ? ---          ?
[task 2024-02-22T20:36:13.011Z] ????????????????????????????????????????????????????????????????????????????????????????????????????????????

Not the end of the world, but I'm guessing it's a UTF-8 issue with the host. Is this configurable anywhere?

Geoff Brown [:gbrown]

Assignee

Comment 1

•

1 year ago

I dumped the environment from a github (good) ui-test-apk-fenix-debug task:

[task 2024-03-01T22:13:22.202Z] ENV SHELL: /bin/bash
[task 2024-03-01T22:13:22.202Z] ENV HOSTNAME: 25c8af835882
[task 2024-03-01T22:13:22.202Z] ENV MOZ_AUTOMATION: 1
[task 2024-03-01T22:13:22.202Z] ENV MOBILE_HEAD_REF: debug-utf8
[task 2024-03-01T22:13:22.202Z] ENV MOBILE_HEAD_REV: 9fa1eae9dde1174da89e04a96be3b89973928bff
[task 2024-03-01T22:13:22.202Z] ENV TASKCLUSTER_ROOT_URL: https://firefox-ci-tc.services.mozilla.com
[task 2024-03-01T22:13:22.203Z] ENV PWD: /builds/worker/checkouts/vcs/fenix
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_WORKER_POOL: mobile-1/b-linux-gcp
[task 2024-03-01T22:13:22.203Z] ENV GOOGLE_APPLICATION_CREDENTIALS: .firebase_token.json
[task 2024-03-01T22:13:22.203Z] ENV GOOGLE_SDK_DOWNLOAD: ./gcloud.tar.gz
[task 2024-03-01T22:13:22.203Z] ENV TASK_WORKDIR: /builds/worker
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_PORT_80_TCP_PORT: 80
[task 2024-03-01T22:13:22.203Z] ENV HOME: /builds/worker
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_WORKER_GROUP: us-central1
[task 2024-03-01T22:13:22.203Z] ENV LANG: en_US.UTF-8
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_NAME: /clever_poincare/taskcluster
[task 2024-03-01T22:13:22.203Z] ENV VCS_PATH: /builds/worker/checkouts/vcs
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_INSTANCE_TYPE: projects/887720501152/machineTypes/n2-standard-4
[task 2024-03-01T22:13:22.203Z] ENV TEST_TOOLS: /builds/worker/test-tools
[task 2024-03-01T22:13:22.203Z] ENV CURL: curl --location --retry 5
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_PORT: tcp://172.17.0.3:80
[task 2024-03-01T22:13:22.203Z] ENV MOBILE_HEAD_REPOSITORY: https://github.com/gbrownmozilla/firefox-android
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_WORKER_LOCATION: {"cloud":"google","region":"us-central1","zone":"us-central1-b"}
[task 2024-03-01T22:13:22.203Z] ENV TERM: dumb
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_PUBLIC_IP: 34.68.235.162
[task 2024-03-01T22:13:22.203Z] ENV HG_STORE_PATH: /builds/worker/checkouts/hg-store
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_PORT_80_TCP_PROTO: tcp
[task 2024-03-01T22:13:22.203Z] ENV MOZ_SCM_LEVEL: 1
[task 2024-03-01T22:13:22.203Z] ENV SHLVL: 0
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_PROXY_URL: http://taskcluster
[task 2024-03-01T22:13:22.203Z] ENV MOBILE_REPOSITORY_TYPE: git
[task 2024-03-01T22:13:22.203Z] ENV SCCACHE_DISABLE: 1
[task 2024-03-01T22:13:22.203Z] ENV REPOSITORIES: {"mobile": "firefox-android"}
[task 2024-03-01T22:13:22.203Z] ENV GOOGLE_PROJECT: moz-fenix
[task 2024-03-01T22:13:22.203Z] ENV GOOGLE_SDK_VERSION: 450
[task 2024-03-01T22:13:22.203Z] ENV GRADLE_OPTS: -Xmx4096m -Dorg.gradle.daemon=false -Dorg.gradle.parallel=false
[task 2024-03-01T22:13:22.203Z] ENV PATH: /builds/worker/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/builds/worker/test-tools:/builds/worker/test-tools/google-cloud-sdk/bin
[task 2024-03-01T22:13:22.203Z] ENV RUN_ID: 0
[task 2024-03-01T22:13:22.203Z] ENV MOBILE_BASE_REPOSITORY: https://github.com/mozilla-mobile/firefox-android
[task 2024-03-01T22:13:22.203Z] ENV TASK_ID: EpuExeoUSq6pIMYvVzqICw
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_WORKER_TYPE: b-linux-gcp
[task 2024-03-01T22:13:22.203Z] ENV PULL_REQUEST_NUMBER: 5844
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_PORT_80_TCP_ADDR: 172.17.0.3
[task 2024-03-01T22:13:22.203Z] ENV TASKCLUSTER_PORT_80_TCP: tcp://172.17.0.3:80
[task 2024-03-01T22:13:22.203Z] ENV OLDPWD: /builds/worker/checkouts/vcs
[task 2024-03-01T22:13:22.203Z] ENV _: /usr/bin/python3

BugBot [:suhaib / :marco/ :calixte]

Comment 2

•

1 year ago

The severity field is not set for this bug.
:jlorenzo, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jlorenzo)

Julien Cristau [:jcristau]

Updated

•

1 year ago

Severity: -- → S3

Flags: needinfo?(jlorenzo)

Priority: -- → P3

Aaron Train [:aaronmt]

Reporter

Comment 3

•

1 year ago

[task 2024-03-14T18:33:34.088Z] ???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????
[task 2024-03-14T18:33:34.088Z] ? OUTCOME ?      MATRIX ID       ? APP NAME ?  TEST FILE NAME  ?       TEST AXIS VALUE        ?     TEST DETAILS      ?
[task 2024-03-14T18:33:34.088Z] ???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????
[task 2024-03-14T18:33:34.088Z] ? [32msuccess[0m ? matrix-y5khjhvyl0zwa ? app.apk  ? android-test.apk ? Pixel2.arm-30-en_US-portrait ? 118 test cases passed ?
[task 2024-03-14T18:33:34.088Z] ???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????

The presence of ANSI escape codes (e.g., [32msuccess[0m) suggests that the output is intended to be color-coded in the terminal as well

Color-coded run from firefox-android https://firefox-ci-tc.services.mozilla.com/tasks/EpuExeoUSq6pIMYvVzqICw/runs/0/logs/public/logs/live.log#L2939

Joe M [:jmahon]

Updated

•

1 year ago

Blocks: monorepo-cleanup
No longer blocks: android-to-gecko-repos

Aaron Train [:aaronmt]

Reporter

Comment 4

•

1 year ago

Ah I see the issue, before migration to Mozilla-Central the previous parent docker image defined an environment with

ENV LANG='en_US.UTF-8' \ LC_ALL='en_US.UTF-8' \ LANGUAGE='en_US:en'

I don't see a base Docker anymore after migration, so it looks like we can just declare this in taskcluster/docker/android-ui-tests/Dockerfile

Julien Cristau [:jcristau]

Comment 5

•

1 year ago

•

Edited

The android-ui-tests image uses android-components as base (https://searchfox.org/mozilla-central/rev/a06d5a8871b1796f2dbd588ab518eaa98507e018/taskcluster/ci/docker-image/kind.yml#253)
The android-components image's Dockerfile still sets LANG (https://searchfox.org/mozilla-central/rev/a06d5a8871b1796f2dbd588ab518eaa98507e018/taskcluster/docker/android-components/Dockerfile#13), but maybe that's not enough; I'll give it a try.

Julien Cristau [:jcristau]

Comment 6

•

1 year ago

https://treeherder.mozilla.org/jobs?repo=try&revision=d042e2ef88367a643492a4284a4f599e390aa6d0&selectedTaskRun=Y8t-eZxXTu2Dhs3V2w7n9g.0 has the same issue.

Geoff Brown [:gbrown]

Assignee

Updated

•

11 months ago

Assignee: nobody → gbrown

Geoff Brown [:gbrown]

Assignee

Comment 7

•

11 months ago

I checked over the various ENV differences, but none of them had an affect on the display of this table. Similarly, I tried changing the google sdk version, checked flank.yml, etc - no change on the table. I also noticed that the MatrixResultsReport.txt artifact is identical for old tasks with the correct formatting and new tasks; I don't understand that.

I found exactly one way to restore the old table display: switch the base image from Debian back to Ubuntu.

Geoff Brown [:gbrown]

Assignee

Comment 8

•

11 months ago

Attached file Bug 1882393 - Use ubuntu for android-ui-tests docker image — Details

Change the android-ui-tests docker image to be based on Ubuntu (as it was on github) rather than Debian, to restore the preferred log formatting of summary results.

Geoff Brown [:gbrown]

Assignee

Comment 9

•

11 months ago

https://treeherder.mozilla.org/jobs?repo=try&revision=3161ff48a33ee1d7d33fafbeb7601a72b251e765

Pulsebot

Comment 10

•

11 months ago

Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09529efb551a Use ubuntu for android-ui-tests docker image r=jcristau,aaronmt

Sandor Molnar[:smolnar]

Comment 11

•

11 months ago

Backed out for causing android failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/9e572acf26f1ecbcd85db08b37daba578256275a

Push with failures

Failure log -> WARNING: could not find Node.js executable later than 12.22.12; ensure node or nodejs is in PATH or set NODEJS in environment to point to an executable.

Flags: needinfo?(gbrown)

Geoff Brown [:gbrown]

Assignee

Comment 12

•

11 months ago

I forgot to test against the android-components ui-tests! They require many of the original packages from https://searchfox.org/mozilla-central/source/taskcluster/docker/android-components/Dockerfile -- I restored much of that.

Flags: needinfo?(gbrown)

Geoff Brown [:gbrown]

Assignee

Comment 13

•

11 months ago

https://treeherder.mozilla.org/jobs?repo=try&revision=3e4b5142c4cc4d9f15bfe06396d4bc8e293f8d1e

Pulsebot

Comment 14

•

11 months ago

Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f95ac036cde Use ubuntu for android-ui-tests docker image r=jcristau,aaronmt

pstanciu

Comment 15

•

11 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/0f95ac036cde

Status: NEW → RESOLVED

Closed: 11 months ago

status-firefox129: --- → fixed

Resolution: --- → FIXED