1882410 - Set VP8Specific/VP9Specific mNumTemporalLayers based on scalability mode

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect, P1)

Description

[C.M.Chang[:chunmin]]

The mNumTemporalLayers in VP9Specific generated in VideoEncoderConfigInternal::ToEncoderConfig() should match the number of temporal layers specified in the given scalability mode. However, it's set to 1 [1, 2] regardlessly.

[1] https://searchfox.org/mozilla-central/rev/9cd4ea81e27db6b767f1d9bbbcf47da238dd64fa/dom/media/webcodecs/VideoEncoder.cpp#257
[2] https://searchfox.org/mozilla-central/rev/9cd4ea81e27db6b767f1d9bbbcf47da238dd64fa/dom/media/platforms/PlatformEncoderModule.h#87

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1882410 - Set temporal layers based on scalability mode

This patch makes the mNumTemporalLayers in VP9Specific generated in
VideoEncoderConfigInternal::ToEncoderConfig match the number of
temporal layers in the given scalability mode.

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1882410 - clang-format VideoEncoder.cpp

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d726ceaa4a36
clang-format VideoEncoder.cpp r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/a0faeb0fdeb6
Set temporal layers based on scalability mode r=media-playback-reviewers,padenot

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d726ceaa4a36
https://hg.mozilla.org/mozilla-central/rev/a0faeb0fdeb6