1882413 - Re-enable one-click set to default in MSIX packages

Status: RESOLVED FIXED

(Firefox :: Installer, enhancement, P1)

Description

[Nick Rishel [:nrishel]]

We believe we have a technical mechanism to determine if one-click will fail in an MSIX package described in Bug 1870895, and therefore should re-enable this feature for systems it will work on.

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1882413 - Part 1: Re-enable MSIX one-click set to default (no change from backout). r=nalexander,mhughes

Backed out changeset 897f98487b4f

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1882413 - Part 3: Modify powershell set default to more accurately mirror the Win32 API set default implementation. r=nalexander,mhughes

Comment 3

[Nick Rishel [:nrishel]]

Attachment: Bug 1882413 - Part 2: Modify `LaunchExecutable` to return `Result`, replaces callback-based argument. r=mhughes

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/911922ed30a0
Part 1: Re-enable MSIX one-click set to default (no change from backout). r=nalexander,mhughes
https://hg.mozilla.org/integration/autoland/rev/ba29a8fe8f7f
Part 2: Modify `LaunchExecutable` to return `Result`, replaces callback-based argument. r=mhughes
https://hg.mozilla.org/integration/autoland/rev/80bda3db4567
Part 3: Modify powershell set default to more accurately mirror the Win32 API set default implementation. r=nalexander,mhughes

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/911922ed30a0
https://hg.mozilla.org/mozilla-central/rev/ba29a8fe8f7f
https://hg.mozilla.org/mozilla-central/rev/80bda3db4567

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Just wanted to leave a note here as well that QA has finished the remaining round of testing on Firefox 125 RC MSIX build (125 beta was already tested previously) and we did not found any new issue.
For the situation that 1-click default works will set everything that's intended as default and for the cases where 1-click default does not work, after manually setting the browser as default it does what's intended.