Closed Bug 188248 Opened 22 years ago Closed 22 years ago

Add string decoding to codesigh's symbol demangling

Categories

(Core :: XPCOM, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: alecf, Assigned: alecf)

Details

Attachments

(1 file)

Playing with codesighs (well, msmap2tsv, specifically) I was running into lots
of symbols that would demangle to "`string'"

This was kind of frustrating because I had no idea what string it referred to.
I played around a bit and was able to reverse-engineer the string-to-symbol
mapping and integrate the decoding into msmap2tsv - so that instead of getting
`string' we get "string: " followed by the actual string value. Since these are
actually symbols, and no the strings themselves, the symbol is just a mangled
version of the first 20 or so characters of the string, so sometimes you get
stuff like
"You can't dereference a NULL nsC"

so I added elipses to such strings, so the resulting demangled symbol name is:
string: "You can't dereference a NULL nsC..."

which should make it easy to grep for, and so forth.

patch forthcoming.
Attached patch decode stringsSplinter Review
and here's the decoding algorithm. The mechanism is described in the bug.
Comment on attachment 110988 [details] [diff] [review]
decode strings

Garrett - do you mind reviewing? this would be really helpful for codesighs
Attachment #110988 - Flags: review?(blythe)
Comment on attachment 110988 [details] [diff] [review]
decode strings

Looks good to me, Alec.
Attachment #110988 - Flags: review?(blythe) → review+
thanks - I figured out a bit more about the string decoding as well (such as the
strings that were previously turning into empty strings) so I checked that in as
well - it was just 2-3 more states to the lexer that is in this patch.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: