1882523 - When adding a new item, pressing Escape when the autocompletion dropdown is displayed should only dismiss the autocompletion, instead of removing the line completely

Status: VERIFIED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Julien Wajsberg [:julienw]]

STR:

1. Open any page.
2. Inspect any element.
3. In the rules view, click on some existing CSS class or add a new property in the element { } part.
4. Start typing a property.
5. When the autocompletion dropdown appears, press Escape.

=> The line is removed completely (KO)

Expected: the line is not removed, only the autocompletion dropdown should be dismissed.
Another "Escape" press should remove the line afterwards.

The same happens for values.

This is the behavior in Chrome, and I find it more intuitive than what happens in Firefox.
(even as somebody who never uses chrome -- so imagine somebody who's used to Chrome Devtools)

Comment 1

[Nicolas Chevobbe [:nchevobbe] [PTO - back January 24]]

We agree that we should align with Chrome's behaviour, which is what we do too in the console too

Comment 2

[Nicolas Chevobbe [:nchevobbe] [PTO - back January 24]]

Attachment: Bug 1882523 - [devtools] Close inplace editor autocomplete on Escape. r=#devtools-reviewers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/714e02409e7f
[devtools] Close inplace editor autocomplete on Escape. r=devtools-reviewers,ochameau.

Comment 4

[Iulian Moraru]

Backed out for causing dt failures on browser_rules_completion-on-empty.js.

• Push with failures

• Failure log

• Backout link

[task 2024-06-04T09:04:59.178Z] 09:04:59     INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_completion-on-empty.js | The popup visibility is correct - 
[task 2024-06-04T09:04:59.179Z] 09:04:59     INFO - Close the suggest completion popup
[task 2024-06-04T09:04:59.185Z] 09:04:59     INFO - Waiting for event: 'popup-closed' on [object Object].
[task 2024-06-04T09:04:59.185Z] 09:04:59     INFO - Got event: 'popup-closed' on [object Object].
[task 2024-06-04T09:04:59.186Z] 09:04:59     INFO - Buffered messages finished
[task 2024-06-04T09:04:59.186Z] 09:04:59     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_completion-on-empty.js | Test timed out - 
[task 2024-06-04T09:04:59.187Z] 09:04:59     INFO - GECKO(1061) | Completed ShutdownLeaks collections in process 1061
[task 2024-06-04T09:04:59.188Z] 09:04:59     INFO - TEST-START | Shutdown
[task 2024-06-04T09:04:59.188Z] 09:04:59     INFO - Browser Chrome Test Summary
[task 2024-06-04T09:04:59.189Z] 09:04:59     INFO - Passed:  1308
[task 2024-06-04T09:04:59.189Z] 09:04:59     INFO - Failed:  1
[task 2024-06-04T09:04:59.190Z] 09:04:59     INFO - Todo:    0
[task 2024-06-04T09:04:59.190Z] 09:04:59     INFO - Mode:    e10s
[task 2024-06-04T09:04:59.194Z] 09:04:59     INFO - *** End BrowserChrome Test Results ***

Comment 5

[Nicolas Chevobbe [:nchevobbe] [PTO - back January 24]]

I'll fix the test failures

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2110a7be1f45
[devtools] Close inplace editor autocomplete on Escape. r=devtools-reviewers,ochameau.

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2110a7be1f45

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on a 2024-06-03 Nightly build on Windows 10.
Verified as fixed on Firefox 128.0b4 and Firefox Nightly 129.0a1 on Windows 10, Ubuntu 22, macOS 14.