Closed Bug 1882587 Opened 2 years ago Closed 2 years ago

Revert to checking supportedRegions for address autofill

Categories

(Toolkit :: Form Autofill, defect)

defect

Tracking

()

RESOLVED FIXED
125 Branch
Tracking Status
firefox124 --- fixed
firefox125 --- fixed

People

(Reporter: issammani, Assigned: issammani)

References

(Regressed 1 open bug)

Details

(Whiteboard: [fxcm-bugs-2023])

Attachments

(2 files)

No description provided.
Assignee: nobody → imani
Attachment #9388200 - Attachment description: WIP: Bug 1882587 - Check supportedRegions as well as experiment flags for address autofill. r=dimi!,sgalich! → Bug 1882587 - Check supportedRegions as well as experiment flags for address autofill. r=dimi!,sgalich!
Pushed by imani@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b5a1215fcc4 Check supportedRegions as well as experiment flags for address autofill. r=dimi

Backed out for causing bc failures on browser_address_autofill_nimbus.js

Backout link

Push with failures

Failure log

Flags: needinfo?(imani)

Yes. I missed that one. Thanks ! Fixed and attempted another land :)

Flags: needinfo?(imani)
Pushed by imani@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6221fa04fb58 Check supportedRegions as well as experiment flags for address autofill. r=dimi
Regressions: 1882746
Blocks: 1882797
See Also: → 1865705
Attachment #9388431 - Flags: approval-mozilla-beta?

Uplift Approval Request

  • Steps to reproduce for manual QE testing: Set extensions.formautofill.addresses.experiments.enabled to false and region to US or CA. Address autofill should still be displayed in preferences.
  • Code covered by automated testing: yes
  • Is Android affected?: no
  • User impact if declined: Some users will have address autofill disabled as nimbus rollout doesn't target all users
  • Risk associated with taking this patch: None
  • Needs manual QE test: no
  • Fix verified in Nightly: no
  • Explanation of risk level: None
  • String changes made/needed: No
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
Attachment #9388431 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [fxcm-bugs-2023]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: