Closed
Bug 1882587
Opened 2 years ago
Closed 2 years ago
Revert to checking supportedRegions for address autofill
Categories
(Toolkit :: Form Autofill, defect)
Toolkit
Form Autofill
Tracking
()
RESOLVED
FIXED
125 Branch
People
(Reporter: issammani, Assigned: issammani)
References
(Regressed 1 open bug)
Details
(Whiteboard: [fxcm-bugs-2023])
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
No description provided.
| Assignee | ||
Updated•2 years ago
|
Assignee: nobody → imani
| Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Attachment #9388200 -
Attachment description: WIP: Bug 1882587 - Check supportedRegions as well as experiment flags for address autofill. r=dimi!,sgalich! → Bug 1882587 - Check supportedRegions as well as experiment flags for address autofill. r=dimi!,sgalich!
Pushed by imani@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b5a1215fcc4
Check supportedRegions as well as experiment flags for address autofill. r=dimi
Comment 3•2 years ago
|
||
Backed out for causing bc failures on browser_address_autofill_nimbus.js
Flags: needinfo?(imani)
| Assignee | ||
Comment 4•2 years ago
|
||
Yes. I missed that one. Thanks ! Fixed and attempted another land :)
Flags: needinfo?(imani)
Pushed by imani@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6221fa04fb58
Check supportedRegions as well as experiment flags for address autofill. r=dimi
| Assignee | ||
Comment 6•2 years ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D203034
Updated•2 years ago
|
Attachment #9388431 -
Flags: approval-mozilla-beta?
Comment 7•2 years ago
|
||
Uplift Approval Request
- Steps to reproduce for manual QE testing: Set extensions.formautofill.addresses.experiments.enabled to false and region to US or CA. Address autofill should still be displayed in preferences.
- Code covered by automated testing: yes
- Is Android affected?: no
- User impact if declined: Some users will have address autofill disabled as nimbus rollout doesn't target all users
- Risk associated with taking this patch: None
- Needs manual QE test: no
- Fix verified in Nightly: no
- Explanation of risk level: None
- String changes made/needed: No
Comment 8•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox125:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
Updated•2 years ago
|
Attachment #9388431 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•2 years ago
|
status-firefox124:
--- → fixed
| Assignee | ||
Updated•2 years ago
|
Whiteboard: [fxcm-bugs-2023]
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•