1882594 - [wpt-sync] Sync PR 44837 - [ProtectedAudience] Add more generateBid() browserSignals tests.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44837 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44837
Details from upstream follow.

Matt Menke <[e-mail]> wrote:

[ProtectedAudience] Add more generateBid() browserSignals tests.

In particular, make sure that bidCount and prevWins are updated or
not as appropriate in the following cases:

• Interest group bids but another group wins the auction.
• Interest group bids but the seller rejects all bids.
• Interest group bids but the seller throws an exception.
• Interest group does not bid.

Add the following tests for bidCount only (they're just less interesting
for prevWins, though could test it in that case, too)

• Interest group does not bid, but another group does and wins the
  auction.
• Interest group bids but the seller rejects the bid,
  and another interest group wins the auction.

Also add a prevWins test where two auctions are run at once (matching
a pre-existing bidCount one), and the unique test case:

• Interest group bids but the seller gives the bid a low score,
  and another interest group wins the auction.

Bug: 40261114
Change-Id: Ib3ea5e9bc78b058dccd91986b0c59ee46a263ad4

Reviewed-on: https://chromium-review.googlesource.com/5323808
WPT-Export-Revision: 6d790086e688b5c013fa433eb6e9253e3777223d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44837 applied with additional changes from upstream: 5ad0ef9981ebb747a5024aab225c7f08abb68f5e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=65e511c0284b1afac2d933212b5ee830e513134b

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 4 subtests

Status Summary

Firefox

OK : 8
FAIL: 29

Chrome

OK : 8
FAIL: 29

Safari

OK : 8
FAIL: 29

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fledge/tentative/generate-bid-browser-signals.https.window.html?17-20 [wpt.fyi]
  • browserSignals.prevWinsMs not affected when ad not used.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.prevWinsMs, no metadata.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.prevWinsMs, with metadata.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.prevWinsMs, different set of ads for each bid.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fledge/tentative/generate-bid-browser-signals.https.window.html?9-12 [wpt.fyi]
  • browserSignals.bidCount leave and rejoin.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.bidCount two auctions at once.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.bidCount incremented when another interest group wins.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.bidCount incremented when seller rejects bid.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fledge/tentative/generate-bid-browser-signals.https.window.html?21-24 [wpt.fyi]
  • browserSignals.prevWinsMs persists across re-join from other top-level origin.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.prevWinsMs leave and rejoin.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.prevWinsMs two auctions at once.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.prevWinsMs not updated when another interest group wins.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fledge/tentative/generate-bid-browser-signals.https.window.html?1-4 [wpt.fyi]
  • Only expected fields present.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.joinCount same joining page.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.joinCount different top-level joining origin.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.joinCount leave and rejoin.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fledge/tentative/generate-bid-browser-signals.https.window.html?25-28 [wpt.fyi]
  • browserSignals.prevWinsMs not updated when seller rejects bid.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.prevWinsMs not updated when seller throws.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.prevWinsMs not updated when no bid.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.prevWinsMs not updated when makes largest bid, but another interest group wins.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fledge/tentative/generate-bid-browser-signals.https.window.html?29-last [wpt.fyi]
  • browserSignals.wasmHelper.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fledge/tentative/generate-bid-browser-signals.https.window.html?5-8 [wpt.fyi]
  • Check recency in generateBid() is below a certain threshold and rounded to multiple of 100 milliseconds.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.bidCount not incremented when ad not used.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.bidCount incremented when ad used.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.bidCount persists across re-join from other top-level origin.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fledge/tentative/generate-bid-browser-signals.https.window.html?13-16 [wpt.fyi]
  • browserSignals.bidCount incremented when seller throws.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.bidCount not incremented when no bid.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.bidCount not incremented when no bid and another interest group wins.: FAIL (Chrome: FAIL, Safari: FAIL)
  • browserSignals.bidCount incremented when makes largest bid, but seller rejects the bid.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cad62978f76e
[wpt PR 44837] - [ProtectedAudience] Add more generateBid() browserSignals tests., a=testonly

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cad62978f76e