1882633 - [wpt-sync] Sync PR 44842 - [PEPC] Restrict Permission Element CSS properties

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44842 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44842
Details from upstream follow.

Andy Paicu <[e-mail]> wrote:

[PEPC] Restrict Permission Element CSS properties

Override AdjustStyle to apply margin and outline offset restrictions.

Use a new property and CascadeFilter to only allow certain properties.

Add multiple TODO's for various other needed style restrictions that are
more complext.

Restrictions based on the following spreadsheet: https://docs.google.com/spreadsheets/d/12A0zc4VKaYegBcr38V1MkHiSXA7rlR983UXTUkNYc6A/edit#gid=0&fvid=230619400

Bug: 1462930
Change-Id: If6f154ac4f2f517281360781da88bfc630ac7d48
Reviewed-on: https://chromium-review.googlesource.com/5301161
WPT-Export-Revision: 84ea31cb243e225cf019ba6ec6cafc136fbc479c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc92192b136a1f88777eb19a3b5ca9affc0af800

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=455d3c444d25e211ad0a57cc23379d374ccb83b9

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 2 subtests

Status Summary

Firefox

OK : 2
PASS: 1
FAIL: 2

Chrome

OK : 2
PASS: 1
FAIL: 2

Safari

OK : 2
PASS: 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/permission-element/invalid-css-properties.html [wpt.fyi]
  • None of the listed properties should be applied: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/permission-element/negative-offset-and-margin.html [wpt.fyi]
  • Negative margins/offset should be changed to 0px: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fad4bb488263
[wpt PR 44842] - [PEPC] Restrict Permission Element CSS properties, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d213fde95c26
[wpt PR 44842] - Update wpt metadata, a=testonly

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/fad4bb488263
https://hg.mozilla.org/mozilla-central/rev/d213fde95c26