1882711 - fatal error: FFVPXRuntimeLinker.h: No such file or directory

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Dan Horák]

A change from yesterday breaks build on ppc64le and s390x with

...
In file included from /home/jenkins/workspace/Firefox-default/label/s390x/firefox/obj-s390x-ibm-linux-gnu/dist/include/mozilla/dom/AnalyserNode.h:11,
                 from AnalyserNodeBinding.cpp:22,
                 from UnifiedBindings0.cpp:132:
/home/jenkins/workspace/Firefox-default/label/s390x/firefox/dom/media/webaudio/FFTBlock.h:12:10: fatal error: FFVPXRuntimeLinker.h: No such file or directory
   12 | #include "FFVPXRuntimeLinker.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

I will work on figuring out the offending commit later today unless someone beats me.

Comment 1

[Petr Sumbera]

I see the same on Solaris SPARC (Intel is OK). This is regression from 1879873 (can you please set it here in the bug?).

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1879873

:padenot, since you are the author of the regressor, bug 1879873, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Paul Adenot (:padenot)]

Sorry about that. Does https://phabricator.services.mozilla.com/D202813 fix it, or cause more problems?

Comment 4

[Dan Horák]

Isn't there a prerequisite patch for D202813? I am getting conflicts in moz.build files.

Comment 5

[Paul Adenot (:padenot)]

Let me rebase it, sorry, my local tree is a little bit old.

Comment 6

[Paul Adenot (:padenot)]

Please try again, same URL, sorry about that.

Comment 7

[Dan Horák]

thanks, it applies cleanly now, but then it fails in mach build with

...
 0:51.37 mozbuild.frontend.reader.SandboxValidationError:
 0:51.37 ==============================
 0:51.38 FATAL ERROR PROCESSING MOZBUILD FILE
 0:51.38 ==============================
 0:51.38 The error occurred while processing the following file or one of the files it includes:
 0:51.38     /home/sharkcz/projects/firefox/media/ffvpx/libavcodec/moz.build
 0:51.38 The error occurred when validating the result of the execution. The reported error is:
 0:51.39     USE_LIBS contains "media_libdav1d_asm", which does not match any LIBRARY_NAME in the tree.
*** Fix above errors and then restart with "./mach build"

my .mozconfig is quite minimal

export CC=/usr/bin/gcc
export CXX=/usr/bin/g++
export PATH=$HOME/.cargo/bin:$PATH
ac_add_options --disable-webrtc
ac_add_options --enable-linker=bfd
ac_add_options --without-wasm-sandboxed-libraries

Comment 8

[Paul Adenot (:padenot)]

I've updated the patch, if you want to retry. Alternatively, if it's feasible for me to attempt to cross compile from Linux Desktop x86_64, happy to give it a go.

Comment 9

[Dan Horák]

Thanks for the update, it fixes my build problem (only ppc64le tested so far, but I believe other platforms will be OK too).

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Bug 1878503 was landed on m-c. Is this fixed for you now?

Comment 11

[Dan Horák]

I think it's fixed (based on my quick local ppc64le rebuild), but will know more in the morning after the nightly CI rebuilds will finish.

Comment 12

[Dan Horák]

and the CI builds (ppc64le and s390x) were successful as well, so feel free to close

Comment 13

[Paul Adenot (:padenot)]

Thanks for double checking, and sorry for the troubles.