1882741 - [Inactive CSS] Do not show a warning when align-content is used on block containers

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Sebastian Zartner [:sebo]]

Bug 1684236 added support for align-content on block containers. This is currently behind the pref layout.css.align-content.blocks.enabled.

Therefore, we should not warn anymore when using align-content in this context if the pref is enabled.

Sebastian

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1882741 - [devtools] Do not show inactive CSS warning for align-content on (inline-)block elements. r=#devtools-reviewers.

Comment 2

[Sebastian Zartner [:sebo]]

Thanks for providing a patch, Nicolas! Actually, I wanted to work on it today, though you were a little faster. :-)

Sebastian

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44ee710d3a49
[devtools] Do not show inactive CSS warning for align-content on (inline-)block elements. r=devtools-reviewers,fluent-reviewers,bolsson,ochameau.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/44ee710d3a49

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1882741 - [devtools] Do not show inactive CSS warning for align-content on (inline-)block elements. r=#devtools-reviewers.

Original Revision: https://phabricator.services.mozilla.com/D203408

Comment 6

[Phabricator Automation]

Uplift Approval Request

• User impact if declined: DevTools Inspector could indicate that a property (align-content) has no effect although it does
• Risk associated with taking this patch: low
• Is Android affected?: no
• Needs manual QE test: no
• String changes made/needed: inactive-css-not-grid-or-flex-or-block-container-fix was added in this patch
• Code covered by automated testing: yes
• Explanation of risk level: devtools-only , covered in test
• Fix verified in Nightly: no
• Steps to reproduce for manual QE testing: -

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This patch adds a new string. Any concerns with taking this uplift into 125.0b3?

Comment 8

[Bryan Olsson [:bolsson]]

Sorry for the delay.
Considering the content and visibility of the string in question, I don't have a concern with uplifting the single string.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4cbc6f98b27c