188275 - Print modules missing in GRE spec file (embedding/config/basebrowser-unix)

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GRE Core, defect)

Description

[Roland Mainz]

Looking at the GRE file spec for *nix
(http://lxr.mozilla.org/seamonkey/source/embedding/config/basebrowser-unix) -
the print modules ("components/libgfxps.so" for the PostScript module and
"components/libgfxxprint.so" for the Xprint module) are missing.
Is that wanted(=e.g. no print support on *nix in GRE) ?

Comment 1

[Chak Nanga]

Someone mor efamiliar with the Unix platform should own this.

Cc:ing Doug and Seawood

Comment 2

[Roland Mainz]

Chak Nanga wrote:
> Someone mor efamiliar with the Unix platform should own this.

Erm... the only question here is:
Should GRE on *nix have print support - [yes]/[no].
AFAIK Win32 and MacOS* have that functionality by default since print support
lives in the main gfx module, only *nix have that functionality in seperate
modules (actually two ones, to be exactly).

Comment 3

[Chak Nanga]

>Should GRE on *nix have print support - [yes]/[no].

I would say [yes]

Comment 4

[Roland Mainz]

Attachment: Patch to add the *nix print modules to embedding/config/basebrowser-unix

Comment 5

[Roland Mainz]

Comment on attachment 111058 [details] [diff] [review]
Patch to add the *nix print modules to embedding/config/basebrowser-unix

Requesting r= ...

Comment 6

[hacker formerly known as [e-mail]]

Comment on attachment 111058 [details] [diff] [review]
Patch to add the *nix print modules to embedding/config/basebrowser-unix

r=cls

Comment 7

[hacker formerly known as [e-mail]]

GRE_MODULE=1 needs to be added to the respective makefiles as well.

Comment 8

[Roland Mainz]

Attachment: Patch for 2003-01-10-08-trunk to add |GRE_MODULE = 1| to gfx/src/{ps|xprint}/Makefile.in

Still requires the other patch to get them into the basebrowser filelist...

Comment 9

[Roland Mainz]

Comment on attachment 111369 [details] [diff] [review]
Patch for 2003-01-10-08-trunk to add |GRE_MODULE = 1| to gfx/src/{ps|xprint}/Makefile.in

Requesting r= (and checkin of both patches if they are OK) ...

Comment 10

[hacker formerly known as [e-mail]]

Comment on attachment 111369 [details] [diff] [review]
Patch for 2003-01-10-08-trunk to add |GRE_MODULE = 1| to gfx/src/{ps|xprint}/Makefile.in

r=cls

Comment 11

[Roland Mainz]

cls:
Can you check both patches "in", please ?

Comment 12

[hacker formerly known as [e-mail]]

The patches have been checked in.