Closed Bug 1882887 Opened 7 months ago Closed 7 months ago

[wpt-sync] Sync PR 44867 - Use exact values to avoid fuzzy matching output.

Categories

(Core :: Graphics: Canvas2D, task, P4)

Product:
Core
Component:
Graphics: Canvas2D
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
125 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 44867 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44867
Details from upstream follow.

John Stiles <johnstiles@google.com> wrote:

Use exact values to avoid fuzzy matching output.

The values originally used in this test for the Perlin noise
frequency (0.025, 0.1) are not exact values in binary floating
point. For instance, 0.025 becomes 0x3ccccccd, or perhaps
0x3ccccccc, depending on how the number is parsed.

We now use numbers which are round in both base 2 and base 10,
and are roughly similar to the original values. For instance,
0.025 has been replaced by 0.03125, which is exactly 0x3d000000.
Visually, this slightly changes the size of the noise ripples
but as a test, it is not meaningfully different otherwise.

Bug: 40045243
Change-Id: I6d708d17d77ed0bc2a53827369a08a7415333059
Reviewed-on: https://chromium-review.googlesource.com/5332945
WPT-Export-Revision: 6fdd0f75247f13cdd2a9736d45a604c20712476c

Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/499ff23d04c8 [wpt PR 44867] - Use exact values to get exactly-matching test results., a=testonly

https://hg.mozilla.org/mozilla-central/rev/499ff23d04c8

Status: NEW → RESOLVED
Closed: 7 months ago
status-firefox125: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.