1883128 - Page Settings Unsetting in Translations and Add Logging

Status: RESOLVED FIXED

(Firefox for Android :: Translations, enhancement, P1)

Description

[Olivia Hall [:olivia]]

There was a bug uncovered when testing bug 1856986 that under certain conditions items would re-toggle after exiting the menu.

I have a slight suspicion there might be a flaw around mapping the values around here in the API, which is used by the update call here.

This API is particularly tricky because it is designed based on this screen, which is seen as three choices of ALWAYS , OFFER or NEVER . However, those toggles are based on seeing ALWAYS and NEVER.

Background:
ALWAYS - adds it to a list of always translate languages
NEVER - adds it to a list of never translate languages
OFFER - is the absence of a language not being on an ALWAYS or NEVER list (so, it defaults back to the "always offer setting")

Comment 1

[Olivia Hall [:olivia]]

Page setting updating is also missing logging, this might be an easy place to add some in.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1883128 - Fix Logic Issue In Setting Page LanguageSettings (#5923)

Comment 3

[BMO Github Automation]

Authored by https://github.com/ohall-m
https://github.com/mozilla-mobile/firefox-android/commit/f12e0f6214d30c73bed8571a0c3777115630c54f
[main] Bug 1883128 - Fix Logic Issue In Setting Page LanguageSettings