1883231 - Searching history show "No results" first before showing results.

Status: RESOLVED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

STR: Search in history for "youtube"

A page comes up with No results for “youtube” and then I wait longer and the results come up.

Also, even after the results show up it sometimes switches back to the "No results" page. I can't reliably reproduce this though.

Comment 1

[Sarah Clements [:sclements]]

I'm not able to reproduce this on 125.0a1. Jeff, do you know what version of Nightly you were on when you saw this? Does it happen the first time you go to firefox view after starting a new session or sporadically after you've already been to firefox view a few times?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: history search.mov

It happens every time. I've attached a screen recording of me reproducing it in Nightly from 2024-03-04

I have a large history because I've set places.history.expiration.max_pages=9999999 but I imagine you should be able to reproduce by running on slower hardware or artificially delaying the time it takes to get results back.

Comment 3

[Nikki Sharpley (:nikkis) (she/her)]

Hey Jeff. Thanks for reporting this!

I haven't been able to reproduce the issue despite setting the following as you've done: places.history.expiration.max_pages=9999999

Are you able to run Firefox Profiler? Hopefully that will glean some more info on why this is happening for you. Thanks!

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Sure here's a profile: https://share.firefox.dev/3TPjWb5
I've included the sqlite threads so you can see the time that's spent query the database.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

It doesn't seem like:
https://searchfox.org/mozilla-central/rev/47a0a01e1f7ad0451c6ba6c790d5c6855df512c1/browser/components/firefoxview/fxview-tab-list.mjs#391
checks if there's an active search query happening. Could that be the problem?

Comment 6

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1883231 - Prevent "no results" from showing if history search is still in progress r=#fxview-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26157b52a8c3
Prevent "no results" from showing if history search is still in progress r=fxview-reviewers,places-reviewers,sfoster

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/26157b52a8c3

Comment 9

[Jonathan Sudiaman [:jsudiaman]]

I've seen this come up again by simulating a slowdown of the db query. Bug 1887220 - Rework map computations in history should make it easier to catch race conditions, I'll take a look.

Comment 10

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1883231 - Don't update search results for a stale query in Firefox View. r?nsharpley

Comment 11

[Mark Banner (:standard8)]

(In reply to Jonathan Sudiaman [:jsudiaman] from comment #9)

I've seen this come up again by simulating a slowdown of the db query. Bug 1887220 - Rework map computations in history should make it easier to catch race conditions, I'll take a look.

Just a note that generally we don't re-open older bugs especially if they've already been "shipped". This makes it harder for tracking regressions (knowing when fixes actually landed) and potentially more difficult if uplifts are required for fixes as it won't be as clear for release drivers.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e3af484623c
Don't update search results for a stale query in Firefox View. r=nsharpley,fxview-reviewers,places-reviewers,Standard8,sidebar-reviewers

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2e3af484623c