1883336 - Extend the quad shader infrastructure to support more patterns

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Extract the quad pattern logic into specific entry points. r=gw

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Move the quad segmentation code into its own function. r=gw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f61047c33e3e
Extract the quad pattern logic into specific entry points. r=gw

Comment 4

[Cristian Tuns]

Backed out for causing webrender bustages

• Backout link
• Push with failures
• Failure Log
• Failure line: [task 2024-03-08T08:25:36.144Z] error: test failed, to rerun pass -p webrender --test angle_shader_validation

Comment 5

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Pass pattern intputs as a 32 bits payload to the quad shaders. r=gw

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Some cleanup in quad.rs. r=gw"

Comment 7

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Move add_quad_to_batch to quad.rs. r=gw

Comment 8

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Simplify quad::add_to_batch. r=gw

Comment 9

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Inline BatchBuilder::add_quad_to_batch. r=gw

A minor cosmetic thing. It does not do much so that's one less indrection when following the code.

Comment 10

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Reformat the imports in quad.rs. r=#gfx-reviewers

This way rust-analyzer stops constantly trying to put it all in a single line.

Comment 11

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Pack the clip planes into 3 varying slots. r=gw

Moving vLocalPos from ps_quad_textured to ps_quad pushed the number of varying slots in ps_quad_mask over the limit (16). vLocalPos is going to be used by some patterns in addition to the texture code so ifdef'ing it out is inconvenient. It is simpler to win back a varying slot by packing the clip planes.

Comment 12

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Pass two ints instead of one as shader input. r=gw

It's convenient for shaders that need to fetch data from two different places and we have a spare slot in the quad header. It's not strictly necessary if we want the spare slot for something else, since we could use the integer gpu buffer as an indirection for when we need more than one address (although that's a tad convoluted and inefficient).

Comment 13

[Nicolas Silva [:nical]]

Attachment: Bug 1883336 - Make patterns work for composited quads. r=gw

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3d3d9ee4329
Extract the quad pattern logic into specific entry points. r=gw
https://hg.mozilla.org/integration/autoland/rev/702ac9db5591
Pack the clip planes into 3 varying slots. r=gw
https://hg.mozilla.org/integration/autoland/rev/364452a457a8
Move the quad segmentation code into its own function. r=gw
https://hg.mozilla.org/integration/autoland/rev/4a2e9567e4ad
Pass pattern intputs as a 32 bits payload to the quad shaders. r=gw
https://hg.mozilla.org/integration/autoland/rev/79e625ff25cf
Some cleanup in quad.rs. r=gw"
https://hg.mozilla.org/integration/autoland/rev/0e99a257162d
Move add_quad_to_batch to quad.rs. r=gw
https://hg.mozilla.org/integration/autoland/rev/909b283eb553
Simplify quad::add_to_batch. r=gw
https://hg.mozilla.org/integration/autoland/rev/2144dd0e8da3
Inline BatchBuilder::add_quad_to_batch. r=gw
https://hg.mozilla.org/integration/autoland/rev/20f68c1570eb
Reformat the imports in quad.rs. r=gfx-reviewers,jrmuizel
https://hg.mozilla.org/integration/autoland/rev/43d89580ba9c
Pass two ints instead of one as shader input. r=gw

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c3d3d9ee4329
https://hg.mozilla.org/mozilla-central/rev/702ac9db5591
https://hg.mozilla.org/mozilla-central/rev/364452a457a8
https://hg.mozilla.org/mozilla-central/rev/4a2e9567e4ad
https://hg.mozilla.org/mozilla-central/rev/79e625ff25cf
https://hg.mozilla.org/mozilla-central/rev/0e99a257162d
https://hg.mozilla.org/mozilla-central/rev/909b283eb553
https://hg.mozilla.org/mozilla-central/rev/2144dd0e8da3
https://hg.mozilla.org/mozilla-central/rev/20f68c1570eb
https://hg.mozilla.org/mozilla-central/rev/43d89580ba9c

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c66fd43449d
Make patterns work for composited quads. r=gw

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1c66fd43449d