1883480 - [wpt-sync] Sync PR 44911 - Add layers variant to remaining filter tests

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44911 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44911
Details from upstream follow.

Andres Ricardo Perez <[e-mail]> wrote:

Add layers variant to remaining filter tests

Modified the existing generated tests that apply filters via
CanvasFilter objects, to also generate variants that apply them via
layers.

These remaining tests did not require a significant redesign. The
variant that uses layers work in the same as the existing tests, just
adding the required beginLayer and endLayer calls.

Bug: 1396372
Change-Id: I381c2938f30cc68f9778adeae05bb7e58e4ba6c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5225024
Reviewed-by: Jean-Philippe Gravel \<[e-mail]>
Commit-Queue: Andres Ricardo Perez \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1267892}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44911 applied with additional changes from upstream: 6a6bbbfed27c43a522aeb2dd3013c84b73c48338, 63d1b04acc3fd2aebeb8973f18c625c7fd3b8773

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ebe07ccfc7d642b630047434b6b5bdc97f5678b

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 30 tests and 1 subtests

Status Summary

Firefox

OK : 24
PASS : 3
FAIL : 25
TIMEOUT: 2

Chrome

OK : 24
PASS : 24
FAIL : 6

Safari

OK : 24
PASS : 3
FAIL : 25
TIMEOUT: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/filters/2d.filter.canvasFilterObject.dropShadow.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/element/filters/2d.filter.layers.dropShadow.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.dropShadow.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.dropShadow.tentative.w.html [wpt.fyi]: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /html/canvas/offscreen/filters/2d.filter.layers.dropShadow.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.layers.dropShadow.w.html [wpt.fyi]: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /html/canvas/element/filters/2d.filter.canvasFilterObject.blur.exceptions.tentative.html [wpt.fyi]
  • Test exceptions on gaussianBlur filter: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.tentative.html [wpt.fyi]
  • Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/filters/2d.filter.canvasFilterObject.dropShadow.exceptions.tentative.html [wpt.fyi]
  • Test exceptions on CanvasFilter() dropShadow object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/filters/2d.filter.canvasFilterObject.turbulence.inputTypes.tentative.html [wpt.fyi]
  • Test exceptions on CanvasFilter() turbulence object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/filters/2d.filter.layers.convolveMatrix.exceptions.html [wpt.fyi]
  • Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/filters/2d.filter.layers.dropShadow.exceptions.html [wpt.fyi]
  • Test exceptions on CanvasFilter() dropShadow object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/filters/2d.filter.layers.turbulence.inputTypes.html [wpt.fyi]
  • Test exceptions on CanvasFilter() turbulence object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.blur.exceptions.tentative.html [wpt.fyi]
  • Test exceptions on gaussianBlur filter: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.blur.exceptions.tentative.worker.html [wpt.fyi]
  • Test exceptions on gaussianBlur filter: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.tentative.html [wpt.fyi]
  • Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.tentative.worker.html [wpt.fyi]
  • Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.dropShadow.exceptions.tentative.html [wpt.fyi]
  • Test exceptions on CanvasFilter() dropShadow object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.dropShadow.exceptions.tentative.worker.html [wpt.fyi]
  • Test exceptions on CanvasFilter() dropShadow object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.turbulence.inputTypes.tentative.html [wpt.fyi]
  • Test exceptions on CanvasFilter() turbulence object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.turbulence.inputTypes.tentative.worker.html [wpt.fyi]
  • Test exceptions on CanvasFilter() turbulence object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.layers.convolveMatrix.exceptions.html [wpt.fyi]
  • Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.layers.convolveMatrix.exceptions.worker.html [wpt.fyi]
  • Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.layers.dropShadow.exceptions.html [wpt.fyi]
  • Test exceptions on CanvasFilter() dropShadow object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.layers.dropShadow.exceptions.worker.html [wpt.fyi]
  • Test exceptions on CanvasFilter() dropShadow object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.layers.turbulence.inputTypes.html [wpt.fyi]
  • Test exceptions on CanvasFilter() turbulence object: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.layers.turbulence.inputTypes.worker.html [wpt.fyi]
  • Test exceptions on CanvasFilter() turbulence object: FAIL (Chrome: PASS, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f206fe6b54f8
[wpt PR 44911] - Add layers variant to remaining filter tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/caef2615698a
[wpt PR 44911] - Update wpt metadata, a=testonly

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f206fe6b54f8
https://hg.mozilla.org/mozilla-central/rev/caef2615698a