1883615 - Move -ldl checks from old-configure to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1883615 - Move libdl checks to moz.configure and make libdl dependencies explicit r=glandium!

The -ldl flag was previously set globally, it's now set for the libs
that use it.

Comment 2

[Landry Breuil (:gaston)]

a bit concerned about this

set_define("HAVE_DLOPEN", have_dl)

since on OpenBSD we have a working dlopen, and no libdl. While testing the complete stack i'll check the resulting config bits..

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4309f75eaa90
Move libdl checks to moz.configure and make libdl dependencies explicit r=glandium

Comment 4

[tszentpeteri]

Backed out for causing build bustages related to check_symbol_in_libs and mbu failures related to python

• Backout link
• Push with failures
• Failure Log for build bustages
• Failure Log for mbu failure

[task 2024-04-17T09:46:06.475Z] 09:46:06     INFO -    CFLAGS= -fcrash-diagnostics-dir=/builds/worker/artifacts
[task 2024-04-17T09:46:06.475Z] 09:46:06     INFO -  checking for vcs source checkout... hg
[task 2024-04-17T09:46:06.504Z] 09:46:06     INFO -  checking for a shell... /bin/sh
[task 2024-04-17T09:46:06.516Z] 09:46:06     INFO -  checking for host system type... x86_64-pc-linux-gnu
[task 2024-04-17T09:46:06.516Z] 09:46:06     INFO -  checking for target system type... x86_64-pc-linux-gnu
[task 2024-04-17T09:46:06.599Z] 09:46:06    ERROR -  Traceback (most recent call last):
[task 2024-04-17T09:46:06.599Z] 09:46:06     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 351, in <module>
[task 2024-04-17T09:46:06.599Z] 09:46:06     INFO -      sys.exit(main(sys.argv))
[task 2024-04-17T09:46:06.600Z] 09:46:06     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 138, in main
[task 2024-04-17T09:46:06.600Z] 09:46:06     INFO -      sandbox.include_file(os.path.join(os.path.dirname(__file__), "moz.configure"))
[task 2024-04-17T09:46:06.600Z] 09:46:06     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 498, in include_file
[task 2024-04-17T09:46:06.600Z] 09:46:06     INFO -      exec(code, self)
[task 2024-04-17T09:46:06.600Z] 09:46:06     INFO -    File "/builds/worker/checkouts/gecko/moz.configure", line 211, in <module>
[task 2024-04-17T09:46:06.600Z] 09:46:06     INFO -      include("build/moz.configure/libraries.configure", when="--enable-compile-environment")
[task 2024-04-17T09:46:06.600Z] 09:46:06     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 872, in include_impl
[task 2024-04-17T09:46:06.600Z] 09:46:06     INFO -      self.include_file(what)
[task 2024-04-17T09:46:06.601Z] 09:46:06     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 498, in include_file
[task 2024-04-17T09:46:06.601Z] 09:46:06     INFO -      exec(code, self)
[task 2024-04-17T09:46:06.601Z] 09:46:06     INFO -    File "/builds/worker/checkouts/gecko/build/moz.configure/libraries.configure", line 65, in <module>
[task 2024-04-17T09:46:06.601Z] 09:46:06     INFO -      dlopen_libs = check_symbol_in_libs(["dl", None], symbol="dlopen")
[task 2024-04-17T09:46:06.601Z] 09:46:06    ERROR -  NameError: name 'check_symbol_in_libs' is not defined
[task 2024-04-17T09:46:06.628Z] 09:46:06     INFO -  *** Fix above errors and then restart with "./mach build"
[task 2024-04-17T09:46:06.701Z] 09:46:06     INFO - Return code: 1
[task 2024-04-17T09:46:06.701Z] 09:46:06  WARNING - setting return code to 2
[task 2024-04-17T09:46:06.701Z] 09:46:06    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2024-04-17T09:46:06.701Z] 09:46:06    FATAL - Running post_fatal callback...
[task 2024-04-17T09:46:06.701Z] 09:46:06    FATAL - Exiting -1
[task 2024-04-17T09:46:06.701Z] 09:46:06     INFO - [mozharness: 2024-04-17 09:46:06.701735Z] Finished build step (failed)
[task 2024-04-17T09:46:06.701Z] 09:46:06     INFO - Running post-run listener: _parse_build_tests_ccov
[task 2024-04-17T09:46:06.702Z] 09:46:06     INFO - Running command: ['/builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/common/bin/python', 'mach', 'python', 'testing/parse_build_tests_ccov.py'] in /builds/worker/checkouts/gecko
[task 2024-04-17T09:46:06.702Z] 09:46:06     INFO - Copy/paste: /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/common/bin/python mach python testing/parse_build_tests_ccov.py
[task 2024-04-17T09:46:06.703Z] 09:46:06     INFO - Using env: {'ACCEPTED_MAR_CHANNEL_IDS': 'firefox-mozilla-central',

Comment 5

[[:sergesanspaille]]

There was a dependency on the updated check_symbol_in_libs function that I missed.

Comment 6

[tszentpeteri]

Backed out for causing multiple failures.

• Backout link
• Push with failures
• Failure Log for Gtest
• Failure Log for gl1c
• Failure Log for bc10
• Failure Log for C
• Failure log:

[task 2024-05-15T09:18:55.053Z] 09:18:55     INFO -  TEST-START | TestStackWalk.StackWalk
[task 2024-05-15T09:18:55.053Z] 09:18:55  WARNING -  TEST-UNEXPECTED-FAIL | TestStackWalk.StackWalk | Expected equality of these values:
[task 2024-05-15T09:18:55.053Z] 09:18:55     INFO -    mExpectedFramePCs
[task 2024-05-15T09:18:55.053Z] 09:18:55     INFO -      Which is: { 0x111b10568-0x111b1058f, 0x111b104dc-0x111b104f6, 0x111b1044c-0x111b10466, 0x111b103bc-0x111b103d6, 0x111b1064c-0x111b10667 }
[task 2024-05-15T09:18:55.053Z] 09:18:55     INFO -    mFramePCs
[task 2024-05-15T09:18:55.053Z] 09:18:55     INFO -      Which is: {}
[task 2024-05-15T09:18:55.053Z] 09:18:55     INFO -  Expected frames:
[task 2024-05-15T09:18:55.054Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.054Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.054Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.054Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.054Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.054Z] 09:18:55     INFO -  Found frames:
[task 2024-05-15T09:18:55.054Z] 09:18:55     INFO -  Function calls data (last skipped: 4):
[task 2024-05-15T09:18:55.054Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.054Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.054Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.055Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.055Z] 09:18:55     INFO -   @ /builds/worker/checkouts/gecko/mozglue/tests/gtest/TestStackWalk.cpp:250
[task 2024-05-15T09:18:55.055Z] 09:18:55  WARNING -  TEST-UNEXPECTED-FAIL | TestStackWalk.StackWalk | Expected equality of these values:
[task 2024-05-15T09:18:55.055Z] 09:18:55     INFO -    mExpectedFramePCs
[task 2024-05-15T09:18:55.055Z] 09:18:55     INFO -      Which is: { 0x111b1064c-0x111b10667 }
[task 2024-05-15T09:18:55.055Z] 09:18:55     INFO -    mFramePCs
[task 2024-05-15T09:18:55.055Z] 09:18:55     INFO -      Which is: {}
[task 2024-05-15T09:18:55.055Z] 09:18:55     INFO -  Expected frames:
[task 2024-05-15T09:18:55.055Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.055Z] 09:18:55     INFO -  Found frames:
[task 2024-05-15T09:18:55.055Z] 09:18:55     INFO -  Function calls data (last skipped: 0):
[task 2024-05-15T09:18:55.056Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.056Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.056Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.056Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.056Z] 09:18:55     INFO -   @ /builds/worker/checkouts/gecko/mozglue/tests/gtest/TestStackWalk.cpp:250
<...>
[task 2024-05-15T09:18:55.083Z] 09:18:55  WARNING -  TEST-UNEXPECTED-FAIL | TestStackWalk.StackWalk | Expected equality of these values:
[task 2024-05-15T09:18:55.083Z] 09:18:55     INFO -    mExpectedFramePCs
[task 2024-05-15T09:18:55.083Z] 09:18:55     INFO -      Which is: { 0x111b1044c-0x111b10466, 0x111b1064c-0x111b10667 }
[task 2024-05-15T09:18:55.083Z] 09:18:55     INFO -    mFramePCs
[task 2024-05-15T09:18:55.083Z] 09:18:55     INFO -      Which is: {}
[task 2024-05-15T09:18:55.083Z] 09:18:55     INFO -  Expected frames:
[task 2024-05-15T09:18:55.083Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.083Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.083Z] 09:18:55     INFO -  Found frames:
[task 2024-05-15T09:18:55.084Z] 09:18:55     INFO -  Function calls data (last skipped: 3):
[task 2024-05-15T09:18:55.084Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.084Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.084Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.084Z] 09:18:55     INFO -    MozDescribeCodeAddress failed
[task 2024-05-15T09:18:55.084Z] 09:18:55     INFO -   @ /builds/worker/checkouts/gecko/mozglue/tests/gtest/TestStackWalk.cpp:250
[task 2024-05-15T09:18:55.084Z] 09:18:55  WARNING -  TEST-UNEXPECTED-FAIL | TestStackWalk.StackWalk | test completed (time: 0ms)
[task 2024-05-15T09:18:55.084Z] 09:18:55     INFO -  TEST-START | cubeb.run_volume_test_short

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/5a89cbc54dd2
Move libdl checks to moz.configure and make libdl dependencies explicit r=glandium

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6540f6047b0
Move libdl checks to moz.configure and make libdl dependencies explicit r=glandium

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a6540f6047b0