1883629 - Update Snappy to version 1.2.0

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task)

Description

[Ryan VanderMeulen [:RyanVM]]

Basically just v1.1.10 with some build fixes included.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Agreed that we want the revision you cite rather than the year old v1.1.10 release. In particular https://github.com/google/snappy/commit/27f34a580be4a3becf5f8c0cba13433f53c21337 has a change that addresses a change in v1.1.10 that we want.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Green Try pushes:
https://treeherder.mozilla.org/jobs?repo=try&revision=f56b6c0b2ebe757f45379eca37709d48c3a260f1
https://treeherder.mozilla.org/jobs?repo=try&revision=db7792d554e0fe3f391fb68ba0daa75a687c1f39

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1883629 - Update Snappy to version 1.2.0.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Updated Try pushes:
https://treeherder.mozilla.org/jobs?repo=try&revision=92b9738be9c3575b541bdbcd112f1fd1e59d4c09
https://treeherder.mozilla.org/jobs?repo=try&revision=369b073f4c04c01c613740c60f0ac2c652beb15e

We may want a follow-up bug for investigating the new Level API they added, but I think sticking with the defaults in this bug for now makes sense. One other thing we should investigate is making sure that we have all the optimizations enabled we expect to have. For example, I see newly-added SNAPPY_HAVE_NEON references but currently no automatic detection & setting of it. I'm happy to poke at that after this bump lands.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7dd31ee906a
Update Snappy to version 1.2.0. r=dom-storage-reviewers,janv

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f7dd31ee906a