1883678 - Web content can receive and dispatch events used by the screenshot component

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect)

Description

[Gregory Pappas [:gregp]]

Attachment: reduced.html

These events can be observed by web content. Additionally, web content can dispatch these events and the Screenshots component will respond! Not good...

• Screenshots:Close
• Screenshots:Copy
• Screenshots:Download
• Screenshots:RecordEvent
• Screenshots:OverlaySelection
• Screenshots:ShowPanel
• Screenshots:HidePanel

Steps to reproduce:

1. Open a fresh profile in Firefox Nightly
2. Load the attached test case

Actual results:
The attached test case can observe these events.
The attached test case is able to modify the user's clipboard and downloads folder.

Expected results:
The attached test case can't do that, ideally.

I found this issue while trying to figure out how to write an automated test for bug 1880634.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1883678 - Dispatch screenshots events to chrome only. r=mconley

Comment 2

[Daniel Veditz [:dveditz]]

Note: we're calling this sec-moderate largely because the user has to invoke a screenshot to be vulnerable. If users were vulnerable all the time on every site we'd dig more into worst-casing exactly what the events could do to see if it might be sec-high.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c13ff57ddd8d
Dispatch screenshots events to chrome only. r=mconley

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c13ff57ddd8d