1883729 - Firefox logs "[GFX1-]: We don't have GTK/EGLWindow with correct size, can't draw." to my terminal when I close About Nightly dialog

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Start Firefox Nightly from the terminal with a fresh profile, e.g.:

$ mkdir /tmp/foo; firefox -profile /tmp/foo 

2. Hamburger Menu|Help|About
3. Close the about dialog (press Esc or click the "x")
4. Check your terminal.

ACTUAL RESULTS:
At the moment the dialog closed, this appears in the terminal:

[GFX1-]: We don't have GTK/EGLWindow with correct size, can't draw.

EXPECTED RESULTS:
No such logging.

Comment 1

[Daniel Holbert [:dholbert]]

I'm using Firefox Nightly 125.0a1 (2024-03-05) (64-bit) on Ubuntu 22.04 with Window Protocol wayland and Compositing WebRender in about:support.

Comment 2

[Daniel Holbert [:dholbert]]

Regression range where this logging started appearing:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3475061cb5df2fea5ed9e240a7508368ff6f23b8&tochange=7346a5d91e93697de1af5ba25e9cb68dd940c215

--> This started with Bug 1880323's patches.

stransky, I wonder if you can reproduce this & if you know what's going on?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1880323

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Will be covered by Bug 1883250.

Comment 5

[Daniel Holbert [:dholbert]]

Thanks!

Comment 7

[Martin Stránský [:stransky] (ni? me)]

We'll see it when you close firefox during paint, i.e. before page is completely rendered. It doesn't imply any issue, it's just a warning. We don't want to paint to hidden windows anyway.

If you feel so we can remove the message.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

It's here: https://searchfox.org/mozilla-central/rev/ba6b30df796659bf70cf8ca60b7bd7a37f617a71/gfx/webrender_bindings/RenderCompositorEGL.cpp#95

Comment 9

[Daniel Holbert [:dholbert]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #7)

We'll see it when you close firefox during paint, i.e. before page is completely rendered. It doesn't imply any issue, it's just a warning. We don't want to paint to hidden windows anyway.

If you feel so we can remove the message.

We should do so, yeah. Shippable builds log essentially nothing to the terminal by default (in the absence of explicit MOZ_LOG etc. requests), and we should align with that expectation here.

(I guess we did remove this logging in the first patch that landed on the regressing bug, here:
https://hg.mozilla.org/integration/autoland/rev/fdcedb217978#l1.12
...but that changeset was backed out in favor of the ones that landed later on, and the logging-removal didn't make it into the final patches that landed.)

Comment 10

[Daniel Holbert [:dholbert]]

Attachment: Bug 1883729: Remove some linux-specific logging for a harmless condition when a window gets closed. r?stransky

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc74b9804f73
Remove some linux-specific logging for a harmless condition when a window gets closed. r=stransky

Comment 12

[Daniel Holbert [:dholbert]]

Attachment: Bug 1883729: Remove some linux-specific logging for a harmless condition when a window gets closed. r?stransky

Original Revision: https://phabricator.services.mozilla.com/D203809

Comment 13

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: no
• Explanation of risk level: Zero behavior change; just removes some logging, from a chunk of code that's only compiled on linux
• Code covered by automated testing: no
• Risk associated with taking this patch: zero
• User impact if declined: Unnecessary log-spam appearing in terminal
• Steps to reproduce for manual QE testing: N/A
• Is Android affected?: no
• Fix verified in Nightly: no
• String changes made/needed: None

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cc74b9804f73

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/291d075bd725