Open Bug 1883778 Opened 7 months ago Updated 7 months ago

Move IsGleanNeeded to a header in toolkit/components/glean

Categories

(Toolkit :: Telemetry, task, P3)

task

Tracking

()

People

(Reporter: chutten, Unassigned)

References

Details

Peter Van der Beken [:peterv] from bug 1883403 comment #6:

BTW, it would be nice to have a IsGleanNeeded function in one of the Glean headers, instead of adding more includes for nsGlobalWindowInner.h to other headers. That's a pretty heavy header to include just for one static non-inlined function. It makes sense to use nsGlobalWindowInner::IsGleanNeeded in Window.webidl, but that can then forward to the other or vice versa.

This will allow us to swap the nsGlobalWindowInner.h include in GleanMetrics.h out.

This might be good work to undertake on or around the time we consider rearranging where Glean puts its webidl in bug 185341.

See Also: 1853411853414
You need to log in before you can comment on or make changes to this bug.