1883795 - Crashed Tabs end up with a weird-looking "chimera" favicon (due to having `crashed.svg` superimposed over the real site's favicon, potentially blending together to create something unrecognizable)

Status: RESOLVED DUPLICATE of bug 1702645

(Firefox :: Theme, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot

STR:

1. Visit https://www.youtube.com/ in Firefox Nightly
2. Hover the tab and note the first PID in the tooltip.
3. In a terminal, run kill -11 [PID] (using the PID from step 2) to kill that process.
4. Look at the favicon in the tab.

ACTUAL RESULTS:
The favicon looks sorta bizarre -- like a weird red hexagon with an exclamation point.
In fact, it's actually the YouTube favicon (a red rounded-rectangle), with Firefox's tab-crashed favicon (referenced as chrome://browser/skin/tabbrowser/crashed.svg) rendered in front of it.

EXPECTED RESULTS:
Just a single favicon -- probably the tab-crashed one? Or, if we really want to include the original site's favicon for some reason, we need to be sure our "crashed" overlay doesn't blend into it -- i.e. we need to add an easy-to-see outline, and perhaps make our overlay a bit smaller and offset-from-center so that the user has a chance to actually see the covered-up favicon.

This is sort of the same issue as discussed in bug 1858539, though it's more general than I had thought when I was filing that bug, so I'm filing this separately/fresh.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: (screenshot of a different bug, posted here by accident)

Here's the problematic rendering from t=16s in my screencast.

At this point, I've manually crashed the YouTube content process, and we've reverted to the previous tab-title for some reason, but left the favicon in-place (and it'll stay like this until I focus the tab).

Comment 2

[Daniel Holbert [:dholbert]]

(Sorry, comment 1 & its attachment was meant for [related] Bug 1883798; I posted the attachment on the wrong bug.)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot of how this looked previously

Regression range where we got to our current rendering:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=658f0e3e5bcc732ea70bc24b6ac46552ee5c0a56&tochange=3813a83e0eddefd11df9e98d1b1eee06e1f50875

I'm attaching a screenshot of the previous rendering, where the icon is superimposed as a smaller "badge" in the upper right of the favicon area, which is easier to recognize/understand (since most of the original favicon is still visible).

Comment 4

[Daniel Holbert [:dholbert]]

In there, the most related looking thing is bug 1693066. And it looks like that's got a regression hanging off of it, which this bug here is a dupe of -- bug 1702645.