1883807 - Enforce a two-character threshold for Suggest matches

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

There was an error in the AMP keywords recently where one keyword was only a single character. Desktop doesn't enforce any threshold for Suggest suggestions, so it was possible to match this keyword and its suggestion after typing only one character. Per Nive, that should never happen and we should enforce a two-character threshold in the client. This is the same two-char threshold urlbar enforces for remote suggestions (search engine suggestions, Merino, etc.).

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1883807 - Enforce a two-character threshold for Suggest matches.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/488c772c7274
Enforce a two-character threshold for Suggest matches. r=daisuke

Comment 3

[Cristian Tuns]

Backed out for causing bc failures in browser_quicksuggest_onboardingDialog.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_onboardingDialog.js | "onboardingSkipLink" == "onboardingReject" - {"filename":"chrome://mochitests/content/browser/browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_onboardingDialog.js","name":"assertFocusOrder","sourceId":745,"lineNumber":998,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"

Comment 4

[Cristian Tuns]

Sorry for this, it looks like this is not the cause for that failure. I will reland it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0879fbe3ec4
Enforce a two-character threshold for Suggest matches. r=daisuke

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/e2a414f7e25c
Backed out changeset 488c772c7274 for causing bc failures in browser_quicksuggest_onboardingDialog.js CLOSED TREE

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a0879fbe3ec4

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fff42f994325
Enforce a two-character threshold for Suggest matches. r=daisuke

Comment 9

[Cosmin Sabou [:CosminS]]

Comment 7 was actually reverted by this merge commit https://hg.mozilla.org/mozilla-central/rev/511c4cab0c008207c1ab7a1d4b14479f4f315f84 so there was no actual change meant by the original patch.
Comment 8 should fix this, until then those changes are not in central until the next merge.

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fff42f994325