1883808 - Enabling window bar title changes text color in tabs

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Cœur Noir]

Attachment: TB_115.8.1_Ubuntu2204_tab_style.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

Using Ubuntu 22.04 with Yaru-dark theme,
Thunderbird 115.8.1 from Ubuntu .deb repository.

I enabled « window title bar » in general settings.

Actual results:

As expected and wished, window title bar is shown

BUT

text color in tabs has changed, ending in black text on ( almost the same ) black background.

I can see that behavior on other Ubuntu22.04 machines.

Thunderbird's light theme is not affected, only when dark theme ( automatic or still. )

Expected results:

Text color in tab should stay the same with or without window title bar.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1883808-titlebar.patch

This is a part of Bug 1842650 which landed on TB 117. We can't port the full patch because toolkit changed other things that are not in 115.

I haven't used phab because this is a 115 bug only.

Comment 2

[Martin Giger [:freaktechnik]]

Comment on attachment 9390328 [details] [diff] [review]
1883808-titlebar.patch

Review of attachment 9390328 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, somehow missed this.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9390328 [details] [diff] [review]
1883808-titlebar.patch

[Approval Request Comment]
User impact if declined: on Linux the tab text can be unreadable
Testing completed (on c-c, etc.): ESR-115 only
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Richard Marti (:Paenglab)]

Rob, I ni you because this patch is for ESR-115 only.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9390328 [details] [diff] [review]
1883808-titlebar.patch

[Triage Comment]
Approved for esr115

Comment 6

[Rob Lemley [:rjl]]

Looks like bug 1884997 worked on the same lines, patch no longer applies.

Comment 7

[Richard Marti (:Paenglab)]

Hmm, I pulled from ESR repository and I see that this patch is checked-in. Have you tried it to land a second time?

Comment 8

[Rob Lemley [:rjl]]

You're right... sorry for the noise.

Comment 9

[Rob Lemley [:rjl]]

https://hg.mozilla.org/releases/comm-esr115/rev/aa65a8243e3f