1883810 - Assertion failure: mTexture, at /builds/worker/checkouts/gecko/dom/webgpu/CanvasContext.cpp:195

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Found while fuzzing m-c 20240125-6497cc2893d1 (--enable-debug --enable-fuzzing)

This has only been reported on Windows.

To reproduce via Grizzly Replay:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch -d --fuzzing -n firefox
$ python -m grizzly.replay.bugzilla ./firefox/firefox <bugid>

Assertion failure: mTexture, at /builds/worker/checkouts/gecko/dom/webgpu/CanvasContext.cpp:195

0|0|xul.dll|mozilla::webgpu::CanvasContext::MaybeQueueSwapChainPresent()|hg:hg.mozilla.org/mozilla-central:dom/webgpu/CanvasContext.cpp:63e18d5ef9ecb56ee260694de696c442f0bd5670|195|0x70
0|1|xul.dll|mozilla::webgpu::CommandBuffer::Commit()|hg:hg.mozilla.org/mozilla-central:dom/webgpu/CommandBuffer.cpp:63e18d5ef9ecb56ee260694de696c442f0bd5670|38|0x76
0|2|xul.dll|mozilla::webgpu::Queue::Submit(mozilla::dom::Sequence<mozilla::OwningNonNull<mozilla::webgpu::CommandBuffer> > const&)|hg:hg.mozilla.org/mozilla-central:dom/webgpu/Queue.cpp:63e18d5ef9ecb56ee260694de696c442f0bd5670|42|0xf0
0|3|xul.dll|mozilla::dom::GPUQueue_Binding::submit(JSContext*, JS::Handle<JSObject *>, void*, JSJitMethodCallArgs const&)|s3:gecko-generated-sources:d7fe9e23fc304392d72803e05ba10ccc5a9b4766984f4c22f9576b2904338cb26bc02fd2f9297a1a5d3c08089928651c71236cdc3b9b4746af5763f8928969fa/dom/bindings/WebGPUBinding.cpp:|22648|0x4d6
0|4|xul.dll|mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy,mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*)|hg:hg.mozilla.org/mozilla-central:dom/bindings/BindingUtils.cpp:63e18d5ef9ecb56ee260694de696c442f0bd5670|3258|0x1e6
0|5|xul.dll|CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:63e18d5ef9ecb56ee260694de696c442f0bd5670|479|0xf2
0|6|xul.dll|js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:63e18d5ef9ecb56ee260694de696c442f0bd5670|573|0x2cf
0|7|xul.dll|js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICFallbackStub*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>)|hg:hg.mozilla.org/mozilla-central:js/src/jit/BaselineIC.cpp:63e18d5ef9ecb56ee260694de696c442f0bd5670|1659|0x6b7

Comment 1

[Bugmon [:jkratzer for issues]]

Unable to reproduce bug 1883810 using build mozilla-central 20240125094742-6497cc2893d1. Without a baseline, bugmon is unable to analyze this bug.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 2

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1883810: refactor(webgpu): subvert/targetContext/presentationContext for `CommandEncoder`s r=#webgpu-reviewers!

Comment 3

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1883810: fix(webgpu): don't enqueue `OffscreenCanvas`es for presentation r=#webgpu-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10f6e9e62fc1
refactor(webgpu): subvert/targetContext/presentationContext for `CommandEncoder`s r=webgpu-reviewers,jimb
https://hg.mozilla.org/integration/autoland/rev/91c44d2b3590
fix(webgpu): don't enqueue `OffscreenCanvas`es for presentation

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/10f6e9e62fc1
https://hg.mozilla.org/mozilla-central/rev/91c44d2b3590