1883839 - [a11y] Consider increasing the "Download" button from the download dialog

Status: RESOLVED FIXED

(Firefox for Android :: Downloads, defect, P2)

Description

[Adina Petridean QA [:apetridean]]

Attachment: download.JPEG

Steps to reproduce

1. Have the Accessibility scanner installed and opened.
2. Navigate to www.thinkbroadband.com/download
3. Tap on the 200 MB file in order to download it.
4. Scan the download dialog.

Expected behavior

No suggestions are made.

Actual behavior

The following suggestion is displayed:
"Consider increasing this item's text foreground to background contrast ratio.
Current: 4:02:1 Foreground: #FBFBFE
Suggested: 4:50:1 Background: #9059FF"

Device information

Firefox version: Firefox 124.0b6 from 06.03.2024
Android device model: Samsung Galaxy S23 Ultra (Android 14)

Comment 1

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Triaging this bug as access-S2, according to the Accessibility Triage Guidelines. The insufficient color contrast makes the text is hard to read for multiple groups of users, especially on mobile when screen glare and direct sunlight could happen more often - these conditions would make any user's ability discern the label text even lower. It is even more important for on-screen labels of controls that are communicating the purpose of the control to a user.

Color contrast of at least 4.5:1 is expected for regular text

Comment 2

[Titouan Thibaud [:titouan]]

Attachment: Bug 1883839 - Fix accessibility issue on the Download button

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c50a71f349c
Fix accessibility issue on the Download button r=android-reviewers,calu

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing linting failures on download_dialog_download_button_background.xml

• backout: https://hg.mozilla.org/integration/autoland/rev/38d626e83e038d73ed52d51d3d5a5edf579cf6e9
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=OYgET0glRT-7PQyFyJwYEA.0&revision=2c50a71f349c3f6abb81974efcd2d5ea5346de52
• failure log: https://treeherder.mozilla.org/logviewer?job_id=458271672&repo=autoland&lineNumber=6577

[task 2024-05-15T12:13:27.034Z] > Task :app:lintFenixDebug FAILED
[task 2024-05-15T12:13:27.034Z] Lint found 1 errors, 1 warnings (10 errors, 180 warnings filtered by baseline lint-baseline.xml). First failure:
[task 2024-05-15T12:13:27.034Z] 
[task 2024-05-15T12:13:27.034Z] /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/res/drawable/download_dialog_download_button_background.xml:5: Error: The resource R.drawable.download_dialog_download_button_background appears to be unused [UnusedResources]
[task 2024-05-15T12:13:27.034Z] 

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e5dce2fd400
Fix accessibility issue on the Download button r=android-reviewers,calu,tchoh

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4e5dce2fd400