1883869 - Make ContentProcessMessageManager::LoadScript become fallible

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task)

Description

[Jens Stutte [:jstutte]]

From bug 1882423 comment 1:

So, looking at the stack here I actually think this is an implementation error in ContentProcessMessageManager::LoadScript.

The problem is that this function calls GetOrCreateWrapper, which is a fallible operation, but never actually checks to see if the wrapper allocation succeeded. If wrapper allocation fails here, then the next point where we dereference the pointer is the stack highlighted here.

Comment 1

[Jens Stutte [:jstutte]]

Would you mind taking this? At a first glance it looks straightforward enough to just do it right.

Comment 2

[Artur Iunusov]

Attachment: Bug 1883869 - Make ContentProcessMessageManager::LoadScript become fallible

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/030183df6dc9
Make ContentProcessMessageManager::LoadScript become fallible r=smaug

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/030183df6dc9