1884030 - [wpt-sync] Sync PR 44961 - [Interop] Add TestDriver support for get_computed_label and get_computed_role

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44961 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44961
Details from upstream follow.

Dan Clark <[e-mail]> wrote:

[Interop] Add TestDriver support for get_computed_label and get_computed_role

Implement the TestDriver APIs get_computed_label and get_computed_role
as specified at [1] and [2].

These are needed for the accname tests in the Interop2024 Accessibility
focus area [3].

These APIs were added to WPT in [4] and are already supported in
WebDriver. Implementing them on window.internals allows us to run
these tests in the normal Chromium test environment, which will help
us in getting the tests passing for Interop2024.

[1] https://w3c.github.io/webdriver/#get-computed-label
[2] https://w3c.github.io/webdriver/#get-computed-role
[3] https://wpt.fyi/results/accname?label=master&label=experimental&aligned&view=interop&q=label%3Ainterop-2024-accessibility
[4] https://github.com/web-platform-tests/wpt/commit/790bb1a2ce2d99442f2e72054dd090a4b5b9c29c

Bug: 325612090
Change-Id: I4d6899a97f1ed26a26b4e3b2e07ef2eb9e6e4b96
Reviewed-on: https://chromium-review.googlesource.com/5328611
WPT-Export-Revision: a9b7ee3133c395cffdecb93f6df8a0931f51ebca

Comment 1

[Alexandra Borovova [:Sasha]]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=3719163039760d2007190b2456aabcadc276dc35

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 142 subtests

Status Summary

Firefox

OK : 1
PASS: 135
FAIL: 7

Chrome

OK : 1
PASS: 132
FAIL: 10

Safari

OK : 1
PASS: 130
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /accname/name/comp_label.html [wpt.fyi]
  • aria-label undefined on img w/ alt: FAIL (Chrome: FAIL, Safari: FAIL)
  • aria-label undefined on img w/o alt: FAIL (Chrome: FAIL, Safari: FAIL)
  • aria-label undefined on img w/ empty alt: FAIL (Chrome: FAIL, Safari: FAIL)
  • aria-label undefined on img w/o alt but w/ title: FAIL (Chrome: FAIL, Safari: FAIL)
  • aria-label undefined on img w/ empty alt but w/ title: FAIL (Chrome: FAIL, Safari: FAIL)
  • button's hidden referenced name (visibility:hidden) with hidden aria-labelledby traversal falls back to aria-label: FAIL (Chrome: FAIL, Safari: FAIL)
  • Hidden button's label should be the empty string: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5c1daead8c6
[wpt PR 44961] - [Interop] Add TestDriver support for get_computed_label and get_computed_role, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8fda4925c5d4
[wpt PR 44961] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c5c1daead8c6
https://hg.mozilla.org/mozilla-central/rev/8fda4925c5d4