1884119 - obj-x86_64-pc-solaris2.11/dist/include/AudioSampleFormat.h:69:34: error: ‘numeric_limits’ is not a member of ‘std’

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect)

Description

[Petr Sumbera]

Steps to reproduce:

Build on Solarid failed with:

12:20.46 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/AudioSampleFormat.h:69:34: error: ‘numeric_limits’ is not a member of ‘std’
12:20.46    69 |   return static_cast<float>(std::numeric_limits<T>::max());
12:20.46       |                                  ^~~~~~~~~~~~~~
12:20.46 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/AudioSampleFormat.h:69:50: error: expected primary-expression before ‘>’ token
12:20.46    69 |   return static_cast<float>(std::numeric_limits<T>::max());
12:20.46       |                                                  ^
12:20.46 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/AudioSampleFormat.h:69:53: error: ‘::max’ has not been declared; did you mean ‘std::max’?
12:20.47    69 |   return static_cast<float>(std::numeric_limits<T>::max());
12:20.47       |                                                     ^~~
12:20.47       |                                                     std::max
..

This is regression from fix for Bug 1858958.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:padenot, since you are the author of the regressor, bug 1858958, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1884119 - Include limits to unbreak the build on Solaris. r?#media-playback-reviewers

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1858958

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31978f6f4be1
Include limits to unbreak the build on Solaris. r=media-playback-reviewers,karlt

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/31978f6f4be1

Comment 7

[Intermittent Failures Robot]

6 failures in 4198 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 6

Platform and build breakdown:

• linux64-snap-amd64-nightly: 6
  • debug: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1884119&startday=2024-03-04&endday=2024-03-10&tree=all