Update fxview-tab-list stories in storybook
Categories
(Firefox :: Firefox View, task, P3)
Tracking
()
People
(Reporter: nsharpley, Unassigned)
References
Details
(Whiteboard: [fidefe-firefox-view])
Attachments
(1 file)
|
201.61 KB,
image/png
|
Details |
Now that we have added indicators (pinned on new tab, bookmark, attention, sound playing) and additional buttons (close, dismiss and media) we should update storybook. We might also need to look into how to import stylesheets to stories rather than manually adding styles, removing room for human error.
Additionally, helpers.js is crashing - see screenshot when attempting to run storybook. We should fix this in the same patch. Regressed by Bug 1859829
Updated•2 years ago
|
Comment 1•2 years ago
|
||
Set release status flags based on info from the regressing bug 1859829
:jsudiaman, since you are the author of the regressor, bug 1859829, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
Comment 2•2 years ago
|
||
There exists bug 1867614 for the console error, let's fix it there and keep this bug scoped to testing the additional functionality.
Updated•2 years ago
|
Updated•2 years ago
|
Comment 3•2 years ago
|
||
I don't know that there's going to be a use case for all of that functionality in storybook - its very specific to Firefox View. And at any rate, we should wait till bug 1880542 is complete.
Description
•