Open Bug 1884193 Opened 2 years ago Updated 2 years ago

Update fxview-tab-list stories in storybook

Categories

(Firefox :: Firefox View, task, P3)

task

Tracking

()

People

(Reporter: nsharpley, Unassigned)

References

Details

(Whiteboard: [fidefe-firefox-view])

Attachments

(1 file)

Now that we have added indicators (pinned on new tab, bookmark, attention, sound playing) and additional buttons (close, dismiss and media) we should update storybook. We might also need to look into how to import stylesheets to stories rather than manually adding styles, removing room for human error.

Additionally, helpers.js is crashing - see screenshot when attempting to run storybook. We should fix this in the same patch. Regressed by Bug 1859829

Set release status flags based on info from the regressing bug 1859829

:jsudiaman, since you are the author of the regressor, bug 1859829, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(jsudiaman)

There exists bug 1867614 for the console error, let's fix it there and keep this bug scoped to testing the additional functionality.

Type: task → defect
Flags: needinfo?(jsudiaman)
No longer regressed by: 1859829
Type: task → defect
Type: defect → task
Keywords: regression
Whiteboard: [fidefe-firefox-view] → [fidefe-firefox-view]

I don't know that there's going to be a use case for all of that functionality in storybook - its very specific to Firefox View. And at any rate, we should wait till bug 1880542 is complete.

Priority: -- → P3
Depends on: 1880542
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: