1884219 - Prevent the extraction and parsing of hrefs containing Javascript

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[James Teow [:jteow]]

Typically our href extraction process shouldn't encounter inline Javascript as it's doubtful our regular expressions would overlap with it.

However, topDown selection of elements could encounter this.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1884219 - Don't extract hrefs from elements if it contains Javascript - r?scunnane!

The extractHrefs method is used to retrieve hrefs from components before passing it
SearchSERPTelemetry to store for future use when observer activity in the network process.
Javascript URLs are uncommon but can accidentally be extracted, especially if a topDown
search for elements is used. No test is added because the presence of the element in an
categorized component will break existing tests.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94321c63dcf4
Don't extract hrefs from elements if it contains Javascript - r=scunnane

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/94321c63dcf4