1884232 - Dismissal acknowledgment tip padding is slightly uneven when it's the last result

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Drew Willcoxon :adw]

Attachment: dismissal-padding.png

When the result at the bottom of the urlbar view is dismissed and replaced with a dismissal acknowledgment tip, the tip's bottom padding is slightly too large, making it unbalanced with its top padding. Please see the attached screenshot; status quo is on the left, fix is on the right.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1884232 - Decrease the bottom padding of the urlbar's dismissal acknowledgment tip so it's balanced with its top padding.

The problem is that the bottom padding of .urlbarView-results is right up
against the bottom padding of the tip when the tip is the last result, making
the effective visual padding 4px + 6px = 10px, whereas the tip's top padding is
only 6px. We just need to subtract the .urlbarView-results padding from the
tip's padding when the tip is the last child.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59fc9dd3d843
Decrease the bottom padding of the urlbar's dismissal acknowledgment tip so it's balanced with its top padding. r=dao

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/59fc9dd3d843