188426 - Height of select is increased by the number of options in an optgroup

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Gérard Talbot]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030109
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030109

If there is 10 options in an optgroup, then the viewport height of the select
will increase like if there is 10 options to show, despite size="1" . One can
see this also in

Debug/Viewer Demos/#8 Form/Optgroup test

http://www.mozilla.org/projects/ui/accessibility/unix/testcase/MAI/DropdownListbox.html

http://bugzilla.mozilla.org/attachment.cgi?id=90457&action=view

Reproducible: Always

Steps to Reproduce:
1. Load a page with a select with an optgroup containing "k" options
2.
3.

Actual Results:  
Viewport height of the select with be k times the number of options within the
optgroup

Expected Results:  
Mozilla should comply with size="n" attribute of select


This *has to* be a recent REGRESSION. In build 2003010604, select with optgroup
were displaying as expected. The select works, functions as expected;
nevertheless there is no workaround for this layout behavior.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is a regression from the maxElementSize.height removal... the new code
looks at the heights of the kids of the dropdown and takes the max; this means
it will take the max of the optgroup heights if there are optgroups (and will be
too big)....

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 111112 [details] [diff] [review]
patch

r+sr=bzbarsky; if this turns out to be a perf problem we can try to replace the
QI with something faster.....

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2002-01-09 16:30 PDT.

Note that the regression was caused by the fix for bug 186953, which was checked
in this morning.