1884359 - Fenix crashes when tapping on Security Connection icon from toolbar

Status: VERIFIED FIXED

(Firefox for Android :: General, defect, P1)

Description

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: crash.rtf

Steps to reproduce

1. Install Fenix and navigate to a page.
2. Tap on the "lock" icon from the navigation bar.

Expected behavior

The info panel is successfully displayed.

Actual behavior

Fenix crashes.

Device information

• Firefox version: Nightly 125.0a1 (2024-03-08)
• Android device: Huawei P40 Lite (Android 10)

Any additional information?

• Please see the crash log attached.
• This crash reproduces constantly.
• It is a regression. Last Good build [2024-03-06] - First Bad build [2024-03-07]

Comment 1

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: 155412-720x1540.mp4

Comment 2

[Ryan VanderMeulen [:RyanVM]]

We're seeing these crashes in the startup-test-fenix-arm-nightly-robo-opt jobs in CI too.
https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.80a1a071cfb2770e/matrices/7582776837098590910

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Thanks to the excellent debugging work done over in bug 1884285, we've reverted the AGP 8.3.0 update ahead of the Nightly builds starting in a few minutes. We'll see if that resolves these crashes.
https://github.com/mozilla-mobile/firefox-android/commit/6e68351872d08075272be21f3aa397a5b12b989b

Comment 6

[Mihai Adrian Carare [:mcarare]]

AGP being the cause of the crash is the most reasonable conclusion because debug builds do not crash, and those builds do not have optimization enabled.

Comment 7

[jackyzy823]

Reference:
https://issuetracker.google.com/issues/311837855
https://github.com/firebase/firebase-android-sdk/issues/5562
https://developer.android.com/build/shrink-code#strict-reference-checks

Comment 8

[jackyzy823]

Reference from AGP 8.3 changelog

https://developer.android.com/build/releases/gradle-plugin#resource-shrinking

Precise resource shrinking on by default
Precise resource shrinking, which removes unused entries from the resources.arsc file and eliminates unused resource files, is on by default. When this shrinking is enabled, your resource table is reduced and only referenced res folder entries are included in the APK.
To turn off precise resource shrinking, set android.enableNewResourceShrinker.preciseShrinking to false in your project's gradle.properties file.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

The failing jobs in CI went green with this backout and Mihai was able to confirm locally that the new Nightly build isn't crashing. Builds will go out to users as soon as they get through Play Store review.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Confirmed that the latest Nightly build from Google Play no longer crashes.