1884446 - Consider replacing my.env with .env in antenna and socorro

Status: NEW

(Socorro :: General, task, P2)

Description

[Daniel Thorn [:relud]]

in response to https://bugzilla.mozilla.org/show_bug.cgi?id=1884408#c0:

Note that while tecken, eliot, and docker compose itself use .env, antenna and socorro use my.env in their Makefile. We may want to change everything to use .env, but that will break existing dev environments

and similar in https://github.com/mozilla-services/socorro/pull/6551#discussion_r1518202275

I think we should change antenna and socorro to use .env for consistency across repos, but also because it's automatically pulled in by docker compose, so devs won't have to exclusively call docker compose through make.

:willkg what do you think?

Comment 1

[Daniel Thorn [:relud]]

:willkg what do you think?

oops, was trying to add a NI? but failed, trying again

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Copying my comment from that discussion which I think I wrote while you were writing up this bug:

https://github.com/mozilla-services/socorro/pull/6551#discussion_r1518306637

Tecken uses .env because that's what peterbe did. Eliot uses .env because I extracted it out of Tecken.

Socorro and Antenna use my.env instead because I don't like using .env for service things because so many other things (docker-compose, honcho, etc) use .env that it sometimes creates problems. Plus .env is a dotfile so it doesn't show up in listings.

Having said that, we should probably standardize on .env and suffer whatever issues come up.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Fixing this will make Socorro and Antenna consistent with Tecken and Eliot which makes things easier. Making it a P2.