Tab pickup/Tabs from other devices section in Firefox View should be hidden when identity.fxaccounts.enabled is false
Categories
(Firefox :: Firefox View, defect)
Tracking
()
People
(Reporter: aoia7rz7l, Unassigned)
Details
Tested on 115.8.0esr and the latest nightly (125.0a1).
Prerequisite:
identity.fxaccounts.enabled is set to false.
STR:
- Open
about:firefoxview. If it doesn't (e.g. in older builds), tryabout:myfirefoxinstead (bug 1764139). - Confirm that the
Tab pickuporTabs from other devicessection in Firefox View contains phrases such as "Pick up where you left off on another device", "Open pages from other devices", "To grab your phone tabs here, first sign in or create an account", or "Sign in or sign up" buttons.
Expected Behavior:
Firefox View should not ask a user to enable Sync when said user has explicitly disable Firefox Accounts.
Actual Behavior:
Firefox View asks user to enable Sync in its Tab pickup/Tabs from other devices section.
mozregression --good 91 --bad 102 --pref browser.tabs.firefoxview:true returned
Last good revision: 23768574eb6d1c1191228316adbc082aaf3a7fd5 (2022-04-27)
First bad revision: 6d8eefa220596a138aceee2b8e93529128c98451 (2022-04-28)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=23768574eb6d1c1191228316adbc082aaf3a7fd5&tochange=6d8eefa220596a138aceee2b8e93529128c98451
Switching bisection method to taskcluster
Getting mozilla-central builds between 23768574eb6d1c1191228316adbc082aaf3a7fd5 and 6d8eefa220596a138aceee2b8e93529128c98451
...
There are no build artifacts for these changesets (these are probably too old).
"Regressed" by bug 1763138 in that this has been an issue from the start. Probably applies to Fenix as well but I haven't checked.
|
||
Comment 1•7 months ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Firefox View' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Comment 2•7 months ago
|
||
This is not something we will support, as you are deliberately disabling your account via the pref which is an uncommon scenerio. The simple workaround if you don't want to see the the synced tabs prompt on Firefox View's "Tabs From Other Devices" in "Recent Browsing" (note "Tab pickup" no longer exists as of 120) is to collapse that container which will persist between sessions.
(In reply to Sarah Clements [:sclements] from comment #2)
you are deliberately disabling your account via the pref which is an uncommon scenerio
There's literally a DisableFirefoxAccounts policy available for enterprise users.
|
|
||
Comment 4•7 months ago
|
||
(In reply to aoia7rz7l from comment #3)
(In reply to Sarah Clements [:sclements] from comment #2)
you are deliberately disabling your account via the pref which is an uncommon scenerio
There's literally a
DisableFirefoxAccountspolicy available for enterprise users.
You're right - I had forgotten about this for enterprise users. I recall we already have a similar bug on file for this, so I'm going to dupe this one instead and add a comment to that bug.
Description
•