1884571 - WaterfallBackground crashes the netmonitor

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[kingof25574]

Attachment: Screenshot at 2024-03-10 15-44-08.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

just watch my sites behavior while fixing backend errors.

Actual results:

[Exception... "Failure" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource://devtools/client/netmonitor/src/widgets/WaterfallBackground.js :: draw :: line 136" data: no]

Expected results:

i don't know

Comment 1

[Julian Descottes [:jdescottes]]

Probably hard to reproduce but we had several reports for issues with this component.
This canvas is used to draw lines over the timeline (rightmost part of the request list).

We can quickly add a try catch around the draw method to avoid errors, but we should probably change the implementation to stop generating this huge canvas.
It's not clear if the error is due to a canvas becoming too big, or if we are trying to update a canvas at the wrong time (eg not initialized).

P2 to add a try catch and avoid breaking the panel. We should handle the deeper investigation in a followup.

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1884571 - [devtools] Catch and log the waterfall background error to the browser console r=#devtools-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d951bbae042e
[devtools] Catch and log the waterfall background error to the browser console r=devtools-reviewers,nchevobbe

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d951bbae042e

Comment 6

[Hubert Boma Manilla (:bomsy)]

Comment on attachment 9391673 [details]
Bug 1884571 - [devtools] Catch and log the waterfall background error to the browser console r=#devtools-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Devtools crashes for developers
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a try catch added stop crashing and instead log the error to the browser console
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9391673 [details]
Bug 1884571 - [devtools] Catch and log the waterfall background error to the browser console r=#devtools-reviewers

Approved for 125.0b2.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/95c484b5cc05