188459 - Make Clone Dbview more effective

Status: NEW

Description

[leon.zhang]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0

Now, when open current message in a opened message window, we will Create a
Dbview for it. we can  do that only in Dbview of main window change.

Reproducible: Always

Steps to Reproduce:

Comment 1

[leon.zhang]

This bug is related to bug 187673

Comment 2

[leon.zhang]

Created attachment 111129 [details] [diff] [review]
Clone for current window when Dbview of main window changed

Comment 3

[leon.zhang]

Created attachment 111133 [details] [diff] [review]
Clone Dbview for opened window when Dbview of main window changed(for discussion)

Comment 4

[(not reading, please use [e-mail] instead)]

does this patch work for both QS and mail views?

Comment 5

[(not reading, please use [e-mail] instead)]

cc dmose, as he was involved with the optimization discussion from bug #187673

Comment 6

[leon.zhang]

current patch works.

Comment 7

[leon.zhang]

I think we should define what can lead Dbview changed firstly .

1) quick search(first time), can lead to create a new Dbview
2) quick search (not first time), which lead to change of content of current Dbview.
3) clear current search, which lead to revover to previous Gdbview..

I think 2) and 3) can be in the same condition(not first time search).

so make a little modification to current patch

Comment 8

[leon.zhang]

4) other conditions:
delete/move/copy/undo, also can lead to content of current dbview, maybe lead to
content change of Dbview.

Comment 9

[leon.zhang]

new thoughts of comments #8
1) If we delete a message or move it to another folder, we cannot select it in
current folder. So, we need not clone Dbview for the opened window, because the
Dbview of main window is a subset of opened message window.

2)undo/redo don't include copy action. 

3)undo/redo will disappear if you change the current folder , and changing
folder will lead to create new Dbview.

Comment 10

[leon.zhang]

Created attachment 111266 [details] [diff] [review]
patch1.0(for discussion)

create a new patch according to previous comments

Comment 11

[[e-mail]]

While you're working on the code I don't suppose you could fix drag and drop?
The drag and drop code in messageWindow.js also assumes folder == view.

Comment 12

[leon.zhang]

1) of comments#9, can explain the drag and drop issue.
after drag, current dbview is still the subset of original dbview.
so need not clone.

as for drop, you need to change folder, and lead to create a new dbview for
destination folder.

Comment 13

[[e-mail]]

Comment on attachment 111266 [details] [diff] [review]
patch1.0(for discussion)

I suggest you keep track of the cloned dbview in case two windows try to reuse
the message window.

Comment 14

[[e-mail]]

Created attachment 112749 [details] [diff] [review]
Like this...

Comment 15

[[e-mail]]

Created attachment 112750 [details] [diff] [review]
Like this, really this time!

Typo :-(

Comment 16

[Wayne Mery (:wsmwk)]

(In reply to comment #15)
> Created an attachment (id=112750) [details]
> Like this, really this time!

patch obsolete?