Make Clone Dbview more effective

NEW
Unassigned

Status

SeaMonkey
MailNews: General
16 years ago
2 years ago

People

(Reporter: leon.zhang, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [has draft patch])

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

16 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0

Now, when open current message in a opened message window, we will Create a
Dbview for it. we can  do that only in Dbview of main window change.

Reproducible: Always

Steps to Reproduce:

Updated

16 years ago
Summary: Make Clone Dbview mor effective → Make Clone Dbview more effective
(Reporter)

Comment 1

16 years ago
This bug is related to bug 187673
(Reporter)

Comment 2

16 years ago
Created attachment 111129 [details] [diff] [review]
Clone for current window when Dbview of main window changed
(Reporter)

Updated

16 years ago
Attachment #111129 - Attachment is obsolete: true
(Reporter)

Comment 3

16 years ago
Created attachment 111133 [details] [diff] [review]
Clone Dbview for opened window when Dbview of main window changed(for discussion)
(Reporter)

Updated

16 years ago
Severity: normal → major
Priority: -- → P1
(Reporter)

Updated

16 years ago
Attachment #111133 - Attachment description: Clone Dbview for opned window when Dbview of main window changed → Clone Dbview for opened window when Dbview of main window changed
does this patch work for both QS and mail views?
cc dmose, as he was involved with the optimization discussion from bug #187673
(Reporter)

Comment 6

16 years ago
current patch works.
(Reporter)

Comment 7

16 years ago
I think we should define what can lead Dbview changed firstly .

1) quick search(first time), can lead to create a new Dbview
2) quick search (not first time), which lead to change of content of current Dbview.
3) clear current search, which lead to revover to previous Gdbview..

I think 2) and 3) can be in the same condition(not first time search).

so make a little modification to current patch
(Reporter)

Comment 8

16 years ago
4) other conditions:
delete/move/copy/undo, also can lead to content of current dbview, maybe lead to
content change of Dbview.
(Reporter)

Updated

16 years ago
Attachment #111133 - Attachment description: Clone Dbview for opened window when Dbview of main window changed → Clone Dbview for opened window when Dbview of main window changed(for discussion)
(Reporter)

Comment 9

16 years ago
new thoughts of comments #8
1) If we delete a message or move it to another folder, we cannot select it in
current folder. So, we need not clone Dbview for the opened window, because the
Dbview of main window is a subset of opened message window.

2)undo/redo don't include copy action. 

3)undo/redo will disappear if you change the current folder , and changing
folder will lead to create new Dbview.
(Reporter)

Comment 10

16 years ago
Created attachment 111266 [details] [diff] [review]
patch1.0(for discussion)

create a new patch according to previous comments
Attachment #111133 - Attachment is obsolete: true

Comment 11

16 years ago
While you're working on the code I don't suppose you could fix drag and drop?
The drag and drop code in messageWindow.js also assumes folder == view.
(Reporter)

Comment 12

16 years ago
1) of comments#9, can explain the drag and drop issue.
after drag, current dbview is still the subset of original dbview.
so need not clone.

as for drop, you need to change folder, and lead to create a new dbview for
destination folder.

Comment 13

16 years ago
Comment on attachment 111266 [details] [diff] [review]
patch1.0(for discussion)

I suggest you keep track of the cloned dbview in case two windows try to reuse
the message window.
(Reporter)

Updated

16 years ago
Attachment #111266 - Attachment description: patch1.0 → patch1.0(for discussion)
(Reporter)

Updated

16 years ago
Attachment #111266 - Attachment is obsolete: true

Comment 15

16 years ago
Created attachment 112750 [details] [diff] [review]
Like this, really this time!

Typo :-(
Attachment #112749 - Attachment is obsolete: true
Product: Browser → Seamonkey

Updated

13 years ago
Assignee: sspitzer → mail
Assignee: mail → nobody
Priority: P1 → --
QA Contact: laurel → message-display

Comment 16

9 years ago
(In reply to comment #15)
> Created an attachment (id=112750) [details]
> Like this, really this time!

patch obsolete?
Component: MailNews: Message Display → View Source
QA Contact: message-display → view-source

Updated

8 years ago
Severity: major → normal
Component: View Source → MailNews: General
QA Contact: view-source → mail

Updated

5 years ago
Whiteboard: [has draft patch]
You need to log in before you can comment on or make changes to this bug.