188465 - DOM computed style doesn't handle border-color:transparent

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The DOM computed style (and thus DOM inspector on the above URL) doesn't handle
border-color: transparent.  It shows garbage data (random numbers?) instead. 
Patch coming.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

This is a diff -uw.  I indented the stuff in the middle. :-)

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 111138 [details] [diff] [review]
patch

This is my first attempt at touching computed style stuff, I think.  Do make
sure I'm doing it right.  (SetIdent with a literal string is the right thing
here, no?  GetBackgroundColor does a table lookup to get the string
"transparent", but that seems silly.)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 111138 [details] [diff] [review]
patch

yep, doing a table lookup here seems silly.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 111138 [details] [diff] [review]
patch

Yep, looks good.  Is 'transparent' a legal value for one of the
-moz-border-*-colors properties?  I don't think we handle that there either, if
it is.

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

It is, and we don't handle it.  Do you want to fix that as well?
http://lxr.mozilla.org/mozilla/source/content/html/style/src/nsComputedDOMStyle.cpp#3154

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

(Why are nsBorderColors::mColor and mTransparent not protected members to
prevent this direct access like this?)

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: testcase for -moz-border-*-colors

Use dom inspector to see bug.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch for -moz-border-*-colors

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 111182 [details] [diff] [review]
patch for -moz-border-*-colors

yup.

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

What I meant with comment 6 was: do we want to create a GetBorderColor() on
nsBorderColors like we do for nsStyleBorder?  No big deal, really.  The patch is
fine as-is and if we do want to change that, it should fall under the auspices
of another bug, but just curious.

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to trunk, 2002-01-10 11:49 PDT.