1884701 - Simplify removing engines during reload engines with search-config-v2

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

When running with search-config-v2 and we are reload engines, we are currently applying the "don't uninstall" policy for the application provided add-on when switching locales/regions - i.e. with search-config, if we removed an application provided engine, but added another app provided engine from the same add-on, then we wouldn't remove the add-on.

However, with search-config-v2 we don't have that restriction, and should always remove engines. This will mean that we can consistently clean them up, which I need for bug 1867288.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1884701 - Move removing engines after SearchService._reloadEngines out to a separate function. r?#search-reviewers!

_reloadEngines is hitting its complexity limits, so we should divide it up a bit more.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1884701 - When running with search-config-v2, simplify removing engines when reloading engines. r?#search-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c688274dbae7
Move removing engines after SearchService._reloadEngines out to a separate function. r=search-reviewers,mcheang
https://hg.mozilla.org/integration/autoland/rev/b357d3c92fb8
When running with search-config-v2, simplify removing engines when reloading engines. r=search-reviewers,mcheang

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c688274dbae7
https://hg.mozilla.org/mozilla-central/rev/b357d3c92fb8