Closed
Bug 1884737
Opened 1 year ago
Closed 11 months ago
Ensure CanvasChild::ReturnDataSurfaceShmem is threadsafe
Categories
(Core :: Graphics: Canvas2D, defect, P3)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
126 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox123 | --- | unaffected |
| firefox124 | --- | unaffected |
| firefox125 | --- | fixed |
| firefox126 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
I think this should be mostly safe, but we should ensure we cannot race here:
https://searchfox.org/mozilla-central/rev/b60cb73160843adb5a5a3ec8058e75a69b46acf7/gfx/layers/ipc/CanvasChild.cpp#490
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Comment 2•1 year ago
|
||
Set release status flags based on info from the regressing bug 1855742
status-firefox123:
--- → unaffected
status-firefox124:
--- → unaffected
status-firefox125:
--- → affected
status-firefox-esr115:
--- → unaffected
|
|
||
Comment 3•11 months ago
|
||
Set release status flags based on info from the regressing bug 1855742
status-firefox126:
--- → affected
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27ed8d34323f
Ensure CanvasChild::ReturnDataSurfaceShmem is threadsafe. r=lsalzman
|
||
Comment 5•11 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
|
|
||
Comment 6•11 months ago
|
||
The patch landed in nightly and beta is affected.
:aosmond, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox125towontfix.
For more information, please visit BugBot documentation.
Flags: needinfo?(aosmond)
|
|
Assignee | |
Comment 7•11 months ago
|
||
Comment on attachment 9390594 [details]
Bug 1884737 - Ensure CanvasChild::ReturnDataSurfaceShmem is threadsafe.
Beta/Release Uplift Approval Request
- User impact if declined: Race condition that can cause extra unnecessary copies
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just a small refactor to make it threadsafe no matter what thread the shmem is released on
- String changes made/needed:
- Is Android affected?: Yes
Flags: needinfo?(aosmond)
Attachment #9390594 -
Flags: approval-mozilla-beta?
|
||
Comment 8•11 months ago
|
||
Comment on attachment 9390594 [details]
Bug 1884737 - Ensure CanvasChild::ReturnDataSurfaceShmem is threadsafe.
Approved for 125.0b4.
Attachment #9390594 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Updated•11 months ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•