Closed Bug 1884907 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 45054 - [anchor] Order-preserving <try-tactic>

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
125 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45054 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45054
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[anchor] Order-preserving <try-tactic>

The order of the "flips" within a \<try-tactic> matters to the final
result, hence we have to preserve it.

  • Use the regular pattern for converting between CSSValueID
    and ComputedStyle-enum (css_value_id_mappings.h).
  • Remove unused ComputedStyleUtils::ValueForPositionTryOptions.

Bug: 40279608
Change-Id: Iae70edc667222acf5854602334bc7973b1f8136b
Reviewed-on: https://chromium-review.googlesource.com/5361839
WPT-Export-Revision: 1c42329e66b882c4dacf27a00db40ffd65e0ad5b

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 27 subtests

Status Summary

Firefox

OK : 3
PASS: 15
FAIL: 52

Chrome

OK : 3
PASS: 61
FAIL: 6

Safari

OK : 3
PASS: 15
FAIL: 52

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-anchor-position/parsing/position-try-options-computed.html [wpt.fyi]
    • Property position-try-options value 'none': FAIL (Chrome: PASS, Safari: FAIL)
    • Property position-try-options value 'flip-block': FAIL (Chrome: PASS, Safari: FAIL)
    • Property position-try-options value 'flip-inline': FAIL (Chrome: PASS, Safari: FAIL)
    • Property position-try-options value 'flip-start': FAIL (Chrome: PASS, Safari: FAIL)
    • Property position-try-options value 'flip-block, flip-inline': FAIL (Chrome: PASS, Safari: FAIL)
    • Property position-try-options value '--foo, --bar': FAIL (Chrome: PASS, Safari: FAIL)
    • Property position-try-options value 'flip-start flip-inline flip-block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property position-try-options value 'flip-start --flop': FAIL (Chrome: PASS, Safari: FAIL)
    • Property position-try-options value '--flop flip-start': FAIL (Chrome: PASS, Safari: FAIL)
    • Property position-try-options has initial value none: FAIL (Chrome: PASS, Safari: FAIL)
    • Property position-try-options does not inherit: FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-anchor-position/parsing/position-try-options-parsing.html [wpt.fyi]
    • e.style['position-try-options'] = "initial" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "inherit" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "unset" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "revert" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "none" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "flip-block" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "flip-block " should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "flip-start, flip-block" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "flip-start flip-inline, flip-block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['position-try-options'] = "flip-start, flip-start" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "flip-start flip-inline flip-block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['position-try-options'] = "flip-block, --foo" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "--bar, flip-block flip-start" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "--foo, --bar, --baz" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "--bar flip-block" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "--bar flip-inline flip-block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['position-try-options'] = "flip-inline --foo" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try-options'] = "flip-inline flip-start --foo" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-anchor-position/parsing/position-try-parsing.html [wpt.fyi]
    • e.style['position-try'] = "flip-inline" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-height none" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "--bar, --baz" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-inline-size --baz, flip-inline" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-block-size flip-inline flip-block, --bar, --baz" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['position-try'] = "normal none" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-width none" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "normal --foo" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "flip-inline" should set position-try-options: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "flip-inline" should set position-try-order: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "flip-inline" should not set unrelated longhands: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-width none" should set position-try-options: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-width none" should set position-try-order: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-width none" should not set unrelated longhands: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "--foo, --bar" should set position-try-options: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "--foo, --bar" should set position-try-order: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "--foo, --bar" should not set unrelated longhands: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-inline-size --foo, flip-inline" should set position-try-options: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-inline-size --foo, flip-inline" should set position-try-order: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-inline-size --foo, flip-inline" should not set unrelated longhands: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-inline-size flip-inline flip-block, --foo, --bar" should set position-try-options: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['position-try'] = "most-inline-size flip-inline flip-block, --foo, --bar" should set position-try-order: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['position-try'] = "most-inline-size flip-inline flip-block, --foo, --bar" should not set unrelated longhands: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4250eeee13d2 [wpt PR 45054] - [anchor] Order-preserving <try-tactic>, a=testonly https://hg.mozilla.org/integration/autoland/rev/53fba18bace9 [wpt PR 45054] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4250eeee13d2
https://hg.mozilla.org/mozilla-central/rev/53fba18bace9

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox125: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.