1884920 - Add wasmBinaryToText

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Yury Delendik (:yury)]

Currently we have only wasmTextToBinary. In the fuzzer configuration, it will be nice to add wasmBinaryToText, so we have human readable test cases.

Comment 1

[Christian Holler (:decoder)]

It might make sense to include this in the general debug configuration since it is likely a feature useful to devs even outside of the fuzzing area.

Comment 2

[Ryan Hunt [:rhunt]]

I think this would be really nice to have. I think we probably could just have this in any debug configuration too.

Comment 3

[Ben Visness [:bvisness]]

it me

Comment 4

[Ben Visness [:bvisness]]

Attachment: Bug 1884920: Replace IndentedPrinter with StructuredPrinter. r=rhunt

Comment 5

[Ben Visness [:bvisness]]

Attachment: Bug 1884920: Overhaul wasm::Dump functions to emit wat. r=rhunt

All wasm::Dump* functions now emit the actual WebAssembly text format.

Depends on D233193

Comment 6

[Ben Visness [:bvisness]]

Attachment: Bug 1884920: Fix janky error message. r=rhunt

"imported i32 with incompatible address type"

wut

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0384ee747b4
Replace IndentedPrinter with StructuredPrinter. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/5bbfc76f48c0
Overhaul wasm::Dump functions to emit wat. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/76f8d1f0a560
Fix janky error message. r=rhunt

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f0384ee747b4
https://hg.mozilla.org/mozilla-central/rev/5bbfc76f48c0
https://hg.mozilla.org/mozilla-central/rev/76f8d1f0a560