1884960 - ScreenHelperAndroid should correctly report if the screen is HDR

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Brad Werth [:bradwerth]]

Bug 1764201 modifies ScreenHelperAndroid to allow it to specify if the screen is HDR-capable, and specifies false by default. This should be fixed to do real detection.

Comment 1

[Cathy Lu [:calu]]

Is this related to the comment from patch 1: "Could you file a bug for it? Android 14 can expose whether this is supported via Display.isHdr and Display.isHdrSdrRatioAvailable."

This seems like follow up work from Bug 1764201 that could be done by the original team?

Comment 2

[az [:az] (back 7/20)]

Attachment: Bug 1884960 - Add HDR capability check to ScreenHelperAndroid

Comment 3

[az [:az] (back 7/20)]

Attachment: Data collection form

Comment 4

[az [:az] (back 7/20)]

We already collect this information for other platforms and this is just adding it for Android - LMK if you have any Qs. See also: Bug 1798067

Comment 5

[Chris H-C :chutten|PTO (back July 13)]

Comment on attachment 9438876 [details]
Data collection form

Actually, there's a new Data Review process in town. Starting May 7, all data collections in projects reviewed in Phabricator also perform data review in Phabricator: https://wiki.mozilla.org/Data_Collection#Firefox_Desktop.2C_Firefox_and_Focus_for_Android.2C_Gecko_.28from_May_7.2C_2024.29

Normally a bot'd come up and let you know about this, but your patch doesn't change a metrics.yaml file so the bot didn't catch it. If it had it'd say code authors and code reviewers together determine what level of review is needed for new or expanded data collections. You might never need to fill out a data review request form again! (For instrumentation in projects reviewed in Phabricator, anyway)

Comment 6

[az [:az] (back 7/20)]

Thanks chutten! I updated the tag on the patch and I'll follow the rest of the instructions once the ask comes through from Herald. (If the ask doesn't come through, I'll move it over to data-classification-low afterwards using the earlier data collection form as justification and keep it at that unless any reviewers disagree).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8182d1d3f86b
Add HDR capability check to ScreenHelperAndroid r=jolin,geckoview-reviewers,jnicol,m_kato

Comment 8

[amarc]

Backed out for causing linting failures at GeckoAppShell.java

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java:935:10 | Parameter type should be final. (com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0e405a22a11
Add HDR capability check to ScreenHelperAndroid r=jolin,geckoview-reviewers,jnicol,m_kato

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a0e405a22a11

Comment 11

[Jim Mathies [:jimm]]

Probe: gfx.supports_hdr