1885053 - [wpt-sync] Sync PR 45071 - [anchor] Generate flips using the try-tactics layer

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45071 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45071
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[anchor] Generate flips using the try-tactics layer

Previous CLs (CL:5349527 and preceding) established a way for
an internal CSSPropertyValueSet (containing CSSFlipRevertValues)
to be added at the "try tactics layer" in the cascade.
This made it possible to carry out the various "flips" required
by CSS Anchor Positioning, even with interleaving anchor()
implemented (crbug.com/41483417).

This CL uses the value specified in the position-try-options
property to generate those value-flipping CSSPropertyValueSets,
and adds them to the cascade.

For now, the flips only apply to insets and sizing properties.
Additionally, values are not yet rewritten during the flip
(e.g. anchor(left) to anchor(right), etc). This behavior will
be added separately.

Bug: 40279608
Change-Id: Iab85e96e343df1f4527a51e60e10154b4c938ee1
Reviewed-on: https://chromium-review.googlesource.com/5366066
WPT-Export-Revision: 86eb3a4d602bcf19675be63864952b2a606a64f1

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=61aea243ca027b88b55f4bb754042b76144828a9

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 3 subtests

Status Summary

Firefox

OK : 3
FAIL : 20

Chrome

OK : 2
FAIL : 12
ERROR: 1

Safari

OK : 3
FAIL : 20

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-anchor-position/try-tactic-base.html [wpt.fyi]
  • flip-start affects base values: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-anchor-position/try-tactic-basic.html [wpt.fyi]
  • --pf : FAIL (Safari: FAIL)
  • --pf flip-block: FAIL (Chrome: FAIL, Safari: FAIL)
  • --pf flip-inline: FAIL (Chrome: FAIL, Safari: FAIL)
  • --pf flip-block flip-inline: FAIL (Chrome: FAIL, Safari: FAIL)
  • --pf flip-inline flip-block: FAIL (Safari: FAIL)
  • --pf flip-start: FAIL (Chrome: FAIL, Safari: FAIL)
  • --pf flip-block flip-start flip-inline: FAIL (Safari: FAIL)
  • --pf flip-inline flip-start flip-block: FAIL (Safari: FAIL)
  • --pf flip-start flip-block: FAIL (Safari: FAIL)
  • --pf flip-inline flip-start: FAIL (Chrome: FAIL, Safari: FAIL)
  • --pf flip-start flip-inline: FAIL (Safari: FAIL)
  • --pf flip-block flip-start: FAIL (Chrome: FAIL, Safari: FAIL)
  • --pf flip-start flip-block flip-inline: FAIL (Safari: FAIL)
  • --pf flip-start flip-inline flip-block: FAIL (Safari: FAIL)
  • --pf flip-inline flip-block flip-start: FAIL (Safari: FAIL)
  • --pf flip-block flip-inline flip-start: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-anchor-position/try-tactic-sizing.html [wpt.fyi]
  • flip-block does not affect sizing: FAIL (Chrome: FAIL, Safari: FAIL)
  • flip-inline does not affect sizing: FAIL (Chrome: FAIL, Safari: FAIL)
  • flip-start affects sizing: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da0d22661875
[wpt PR 45071] - [anchor] Generate flips using the try-tactics layer, a=testonly
https://hg.mozilla.org/integration/autoland/rev/96b6a6f3ef26
[wpt PR 45071] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/da0d22661875
https://hg.mozilla.org/mozilla-central/rev/96b6a6f3ef26