1885170 - Remove `glean_timestamp` from recorded events in test mode

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Jan-Erik Rediger [:janerik]]

When we default-enabled the wall-clock timestamp it also got exposed to testing.
Reasonably tests expect no extras when none are recorded by them.

Yet now there are values. This was exposed in https://github.com/mozilla-mobile/firefox-android/pull/6005 (test run).

For the moment we fix that in a-c directly (quicker, no Glean release needed). But we should just filter those out in the Glean SDK.

This work includes reverting the change in a-c.

Comment 1

[BMO Github Automation]

Authored by https://github.com/badboy
https://github.com/mozilla-mobile/firefox-android/commit/55761191324df298ea5a644e34baef9f0e88eff7
[main] Bug 1885170 - Wrap the Glean SDK EventMetricType to overwrite the testGetValue function.

Comment 2

[BMO Github Automation]

Attachment: [mozilla/glean] Bug 1885170 - Remove `glean_timestamp` from event extras in tests (#2776)

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1885170 - Remove EventMetricType wrapper from a-c again r?TravisLong

Previously added as a workaround in https://github.com/mozilla-mobile/firefox-android/pull/6005
The new Glean update will fix that in the SDK directly.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6afa6592b309
Remove EventMetricType wrapper from a-c again r=TravisLong,android-reviewers,mcarare

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6afa6592b309