1885184 - Port bug 232598 - getAttribute for xul-elements should return null for unset attributes

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[Magnus Melin [:mkmelin]]

Port bug 232598. xul returns an empty string for unset attributes. It will now return null, like html.

These may or may not be affected: https://searchfox.org/comm-central/search?q=getAttribute\([^)]*\)&case=false&regexp=true&path=
Cases like https://searchfox.org/comm-central/rev/30b643653161934450131c482edf222e9d1f2ae4/mail/test/browser/composition/browser_attachment.js#150 need to change.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1885184 - Port bug 232598 - getAttribute for xul-elements should return null for unset attributes. r=freaktechnik

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1e34b1f80c83
Port bug 232598 - getAttribute for xul-elements should return null for unset attributes. r=freaktechnik

Comment 3

[Martin Giger [:freaktechnik]]

https://treeherder.mozilla.org/logviewer?job_id=451282575&repo=comm-central&lineNumber=2934 and friends seem like they would be from this, too.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1885184 - more adjustments for getAttribute(). r=#thunderbird-reviewers

Fixes mail/base/test/browser/browser_tagsMenusAndKeys.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/97dc38ed8d17
more adjustments for getAttribute(). r=leftmostcat

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1885184 - getAttribute fix for browser_extension_update_background_noprompt.js. r=#thunderbird-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4180f44afaf0
getAttribute fix for browser_extension_update_background_noprompt.js. r=leftmostcat