188527 - AIX: Linker errors when building GTK2 as default toolkit

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Philip K. Warren]

When building on AIX with --enable-default-toolkit=gtk2, several linker errors
prevent the build from completing. In most instances we only need to add the X11
library to the link line.

Comment 1

[Philip K. Warren]

Attachment: Fix linker errors on AIX

Comment 2

[hacker formerly known as [e-mail]]

Comment on attachment 111191 [details] [diff] [review]
Fix linker errors on AIX

I stlll think that pkg-config should have listed those libs. r=cls

Comment 3

[Christopher Blizzard (:blizzard)]

hp, what do you think about the problems we've been seeing on solaris and AIX
with pkg-config not listing all of the right libs?

Comment 4

[Philip K. Warren]

Checking in embedding/browser/gtk/tests/Makefile.in;
/cvsroot/mozilla/embedding/browser/gtk/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.25; previous revision: 1.24
done
Checking in modules/plugin/base/src/Makefile.in;
/cvsroot/mozilla/modules/plugin/base/src/Makefile.in,v  <--  Makefile.in
new revision: 1.82; previous revision: 1.81
done
Checking in modules/plugin/samples/default/unix/Makefile.in;
/cvsroot/mozilla/modules/plugin/samples/default/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.25; previous revision: 1.24
done
Checking in widget/src/gtk2/mai/Makefile.in;
/cvsroot/mozilla/widget/src/gtk2/mai/Makefile.in,v  <--  Makefile.in
new revision: 1.7; previous revision: 1.6
done
Checking in widget/src/gtkxtbin/Makefile.in;
/cvsroot/mozilla/widget/src/gtkxtbin/Makefile.in,v  <--  Makefile.in
new revision: 1.11; previous revision: 1.10
done

Comment 5

[Philip K. Warren]

Had to back out this patch because it broke the Linux GTK2 tinderbox. I believe
I forgot to add the $(XLDFLAGS) parameter in one of the Makefiles. Will post a
better patch tomorrow.

Comment 6

[Philip K. Warren]

Attachment: Added missing $(XLDFLAGS)

Comment 7

[hacker formerly known as [e-mail]]

Comment on attachment 111301 [details] [diff] [review]
Added missing $(XLDFLAGS)

r=cls

Comment 8

[Philip K. Warren]

Checked in.

Comment 9

[Philip K. Warren]

Fixed with yesterday's checkin.

Comment 10

[Philip K. Warren]

Verified in today's build.

Comment 11

[Robin Lu]

*** Bug 186567 has been marked as a duplicate of this bug. ***