1885280 - Visual glitch displayed while selecting a translation language

Status: VERIFIED FIXED

(Firefox for Android :: Translations, defect, P1)

Description

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: az_recorder_20240314_112152.mp4

Prerequisites

1. Go to the three-dot menu - Settings - About Firefox Nightly, and tap 5 times on the logo.
2. Exit the About Firefox Nightly, and go to the Secret Settings.
3. Enable the "Enable Firefox Translations" toggle.
4. Set your device's OS to English - US.

Steps to reproduce

1. Open a translatable page (i.e. yr.no), and tap on the translation icon from the toolbar.
2. Tap on the dropdown arrow from the "Translate from" section.
3. Select a language.

Expected behavior

The language is selected without issues.

Actual behavior

A visual glitch with the languages list is displayed above the translation sheet for a second.

Device information

• Firefox version: Firefox 125 (2024-03-13)
• Android device model: Realm C35 (Android 12), Google Pixel 6 (Android 14), Samsung Galaxy S24 (Android 14)

Any additional information?

• This issue also reproduces while selecting a language from "Translate to" list.

Comment 1

[Olivia Hall [:olivia]]

Hi Mihai, this feels a little reminiscent of the compose bug 1874212 to me, but I don't fully remember the behavior, what is your quick take?

Comment 2

[Mihai Adrian Carare [:mcarare]]

I think this might be related to the closing animation of the menu due to the dynamic placement. So it might be an issue with our Menu implementation or in the Compose DropdownMenu for this specific use case.

We should check if it is still reproducible, because a Compose update landed in the mean time that directly influences the placement of a DropdownMenu.

Also, although the glitch looks bad, I don't think this should be an S3 since it does not prevent the usage of the feature.

Comment 3

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: az_recorder_20240405_145634.mp4

This issue is still reproducible on Latest Nightly 126 (2024-04-05) under Realme C35 with Android 12. Attaching a more recent video. Updating the severity as Mihai suggested.

Comment 4

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1885280 - Hide ContextualMenu after selecting language.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb740d0ba7a1
Hide ContextualMenu after selecting language. r=android-reviewers,ohall

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/eb740d0ba7a1

Comment 7

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Fenix Nightly 126.0a1 from 4/11, with the following devices:

• Samsung Galaxy S24 (Android 14),
• Google Pixel 6 (Android 14),
• Lenovo tab M10 (Android 10),
• Xiaomi mi8 Lite (Android 10),
• Oppo Find X3 Lite (Android 11), and
• Realme C35 (Android 12).